Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currencies - part 4 #779

Merged
merged 9 commits into from
Nov 4, 2017
Merged

Currencies - part 4 #779

merged 9 commits into from
Nov 4, 2017

Conversation

Changaco
Copy link
Member

@Changaco Changaco commented Nov 3, 2017

Continuing the work on #182 this branch contains bug fixes. The branch.sql is already deployed since yesterday.

For some reason we're getting `(null,null)` from the `sum` function instead of a plain `null`, so the standard `coalesce` function doesn't kick in and we end up with invalid money amounts in the database. I haven't found a way to fix the problem at the source, so I created a `coalesce_currency_amount` function instead.
@Changaco Changaco added the Review label Nov 3, 2017
@Changaco Changaco merged commit f926ed8 into master Nov 4, 2017
@Changaco Changaco deleted the currencies-4 branch November 4, 2017 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant