Currencies - part 3 #769
Merged
Currencies - part 3 #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
converted tables: cash_bundles, debts, exchanges, transfers
Changaco
force-pushed
the
currencies-3
branch
2 times, most recently
from
a118b3c to
f68edff
Compare
|
I've just finished a full review. Most of the changes are actually straightforward, but there are a lot of them… I found and fixed a few bugs. It's still far from perfect but hopefully it'll be good enough for now. |
converted columns: goal, giving, receiving, taking, leftover
Changaco
force-pushed
the
currencies-3
branch
from
f68edff to
0b5ad11
Compare
|
Found another bug while working on account migration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third step towards #182. This is the big one.