Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various #2283

Merged
merged 10 commits into from
Oct 13, 2023
Merged

Various #2283

merged 10 commits into from
Oct 13, 2023

Conversation

Changaco
Copy link
Member

No description provided.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

www/explore/repositories.spt Outdated Show resolved Hide resolved
www/explore/individuals.spt Outdated Show resolved Hide resolved
www/explore/organizations.spt Outdated Show resolved Hide resolved
www/explore/recipients.spt Outdated Show resolved Hide resolved
www/explore/teams.spt Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #2283 (d425241) into master (12296db) will increase coverage by 0.01%.
The diff coverage is 35.71%.

Files Coverage Δ
liberapay/wireup.py 83.71% <69.23%> (-0.21%) ⬇️
liberapay/utils/__init__.py 70.77% <6.66%> (+0.21%) ⬆️

... and 2 files with indirect coverage changes

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

This new page is intended to combine and replace `/explore/{individuals,organizations,teams}`. The separate pages were never fully satisfactory, and they've been getting less useful since the mangopay crisis.
@Changaco Changaco merged commit aee64f4 into master Oct 13, 2023
2 of 3 checks passed
@Changaco Changaco deleted the various branch October 13, 2023 09:31
@Changaco
Copy link
Member Author

Deployment of these changes has been delayed by WeblateOrg/weblate#10187.

@sentry-io
Copy link

sentry-io bot commented Oct 16, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ValueError: too many values to unpack (expected 2) liberapay.wireup in cast_localized_string View Issue
  • ‼️ ValueError: too many values to unpack (expected 2) liberapay.wireup in cast_localized_string View Issue
  • ‼️ ValueError: too many values to unpack (expected 2) liberapay.wireup in cast_localized_string View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant