Improve the handling of “unsettling” profiles (a.k.a. Not Safe For Work) #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changaco
requested changes
Dec 11, 2021
There was a problem hiding this comment.
- JavaScript isn't needed (and therefore shouldn't be used) to implement opting-in to view unsettling profiles.
- The CSS classes used to apply the blur effect can be generalized, i.e.
blur-3pxandblur-4pxinstead ofpanel-blur,repo-search-blurandmini-user-blur. - The
base.htmltemplate isn't the right place to implement hiding unsettling profiles.profile-base.htmlis more appropriate.
liberapay/constants.py
Outdated
| ('hide_giving', (_("Hide total giving from others."), False)), | ||
| ('hide_receiving', (_("Hide total receiving from others."), False)), | ||
| ('hide_from_search', (_("Hide this profile from search results on Liberapay."), True)), | ||
| ('profile_noindex', (_("Tell web search engines not to index this profile."), True)), | ||
| ('hide_from_lists', (_("Prevent this profile from being listed on Liberapay."), True)), | ||
| ('is_unsettling', (_("Mark this profile as unsettling"), True)), |
There was a problem hiding this comment.
This checkbox label is too terse, and its (lack of) punctuation isn't consistent with the other labels.
| @@ -40,6 +40,7 @@ langs = participant.get_statement_langs() | |||
|
|
|||
| show_income = not participant.hide_receiving and participant.accepts_tips | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
This extraneous blank line should be removed.
| {{ _( | ||
| "{username} has a repository named {repo_name} in their {platform} account", | ||
| "has a repository named {repo_name} in their {platform} account", | ||
| username=('<a href="/{0}/">{0}</a>'|safe).format(owner.username), |
There was a problem hiding this comment.
If the username variable isn't used in the string anymore, then it should be removed from the arguments passed to the translation function. However, the larger problem here is that this change assumes that the username is at the beginning of the sentence in every language. A cleaner solution would be to generate the possibly-blurred avatar+username box with a macro or block assignment, and pass it to the translation function in the username argument.
Changaco
changed the title
…y.com into set-profile-unsettling
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #1965. Implements functionality that allows users to mark their profile as unsettling. These profiles are then blurred/hidden when viewed by other users. Users can only see the content of unsettling profiles after being warned the profile contains unsettling content and confirming that they still want to view the profile.