Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add link to translation platform to language choice menu #1071

Closed
wants to merge 5 commits into from

Conversation

jibe-b
Copy link

@jibe-b jibe-b commented Apr 13, 2018

First step towards #1070

Language selection menu should change from:

image

to
image

  • display translation coverage percentage only when <= 99%
  • display translation coverage percentage in smaller size
  • display translation coverage percentage aligned on the right

@jorgesumle
Copy link
Contributor

When you make pull requests with changes to the design, it's a good idea to provide some captures to make the review easier for us and allow more people to participate in the debate (even non-coders). It's also a good idea to add WIP (work in progress) in the title, so that people know you are working on it and it's not ready to merge.

@jibe-b jibe-b changed the title add link to translation platform to language choice menu [WIP] add link to translation platform to language choice menu Apr 13, 2018
@jibe-b
Copy link
Author

jibe-b commented Apr 13, 2018

@jorgesumle <span style="float:right><small> is not ideal. I am not an html expert, what is the best optimized and consistent approach? all style in the span?

@jorgesumle
Copy link
Contributor

@jibe-b, there is a Sass file called style/base/navbar.scss for the navbar. HTML is the language for describing the structure of Web pages, while CSS is meant for the presentation. It's not recommended to include CSS code in an HTML file.

You can write <span class="translation-progress"> and make it smaller via CSS. But I guess <small class="translation-progress"> is not wrong and is another option (See small element recommendation):

The small element represents side comments such as small print.

@Changaco
Copy link
Member

Closing in favor of #1080.

@Changaco Changaco closed this Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants