-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NSFW flag for accounts #1965
Comments
The database schema changes and admin part of this have been implemented in #2024. I've used the word “unsettling” instead of the abbreviation NSFW in the code and the admin interface. What's left to do:
|
I am looking to contribute to the repository for the first time. Does this issue still need to be worked on? |
Yes. |
I've looked into this task more and am interested in working on it. I understand where users should be able to set their profile as "unsettling", but where users be able to select to opt in to viewing "unsettling" profiles? |
On every page which would show an unsettling profile if the user had already opted-in to see them. There should probably be two buttons: one to deactivate the NSFW filter for only one page view, and another one to deactivate it permanently (by setting a cookie). |
Would something like what is shown in the video work? (this is just a proof of concept) If the user opts in to always seeing unsettling profiles then they will not be shown this prompt whenever they visit an unsettling profile. Screen.Recording.2021-11-21.at.10.27.43.PM.mov |
It's a good start.
|
If the profile (including the avatar) should be completely hidden, how should the profile appear in search results and other places where users can access profiles? There are lots of places on the site where you can see a user's avatar before clicking on their entire profile. |
In the exploration pages and search results we should probably blur the NSFW profiles. (I mean blur the whole box, not just the avatar.) |
Do want to blur unsettling profiles in every single place they are used on the site? As I am looking through the code I am noticing a lot of spots where avatar_img(...) is used and then the username is listed. I would have to include a lot of checks to make sure both the username and avatar are blurred since the username is often listed separately outside of the avatar_img() macro. I am just trying to avoid making many unnecessary changes. Right now I am blurring unsettling profiles on the exploration pages and search results. |
Blurring only in the exploration and search pages is fine. I'll add blurs elsewhere later if I think they're necessary. |
Ok, any advice on how to go about testing? I have looked at some of the other test files but don't see any files where I think these tests may fit in or any other tests that test a similar type of functionality that I could use as a reference. |
I would probably put the tests in the I guess the things to check are:
|
Ok. Doesn't the test_participant_can_modify_privacy_settings already check that a user can mark and unmark their profile as unsettling? |
No, because it's not a privacy setting. |
Right now |
If |
I went through and changed the naming from privacy to visibility for everything that was related to the |
Yes, it should be possible to mark a team as unsettling. Ideally the other team members would be informed of the change, but you don't have to try to implement that, it's a larger issue (#134). |
Ok, I went and submitted a PR. |
Liberapay profiles probably need a “Not Safe For Work” flag that can be set by profile owners and Liberapay admins, similar to the privacy settings but for a different purpose.
The text was updated successfully, but these errors were encountered: