Fix reloading the integration from hanging #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knightzac19
changed the title
|
@dotvezz fixed my branch from the main merge, should pass workflows now. |
dotvezz
approved these changes
Sep 16, 2024
|
thanks for this PR. Sometimes my machine would go offline (wifi connection issue), and I would try to reload it, and that issue happens. Now, if I reload it, will it attemp to connecto the machine? |
|
Yea, if the entity isn't showing "unavailable"(it should still work if it is, just didn't test that scenario as much), reload should work now. I tested my 475 by kicking it off wifi and then reloading, it correctly reconnected and started working again. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing reload on the integration, it would always hang and all entities would become unavailable. This would require homeassistant to completely reboot before the integration would work again. Changing it to use the built in platforms unload function has fixed this behavior.