Make GsymResolver::find_line_info() report more error context #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We originally introduced find_line_info_impl() in GsymResolver::find_line_info() to short circuit on the various error paths, because it was way too cumbersome to report custom errors on each. By now we have the means for more concise error chaining and so we remove this internal function and report more detailed errors for each of the potential early returns. Signed-off-by: Daniel Müller <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
==========================================
- Coverage 85.30% 85.08% -0.22%
==========================================
Files 37 37
Lines 4654 4613 -41
==========================================
- Hits 3970 3925 -45
- Misses 684 688 +4
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We originally introduced find_line_info_impl() in
GsymResolver::find_line_info() to short circuit on the various error paths, because it was way too cumbersome to report custom errors on each.
By now we have the means for more concise error chaining and so we remove this internal function and report more detailed errors for each of the potential early returns.