MacOS Deadkey support #1588
Merged
MacOS Deadkey support #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiegeLord
force-pushed
the
macos_deadkeys
branch
2 times, most recently
from
a228608 to
bee5c7b
Compare
SiegeLord
force-pushed
the
macos_deadkeys
branch
3 times, most recently
from
1d54970 to
a45c751
Compare
We replace the old, somewhat flaky direct reads from NSEvent with the use of UCKeyTranslate. It is still not perfect, so we do a bunch fo hacks to get the various keys repeating and emitting the correct CHAR events.
…y to ALLEGRO_KEY_BACKSLASH2 on MacOS. The first is uncontroversial. The second is unclear, but perhaps a decent choice? https://discussions.apple.com/thread/8133633?sortBy=rank says that the Usage ID of that key is 0x64. https://github.com/tmk/tmk_keyboard/wiki/USB:-HID-Usage-Table#note-9 says that that usage maps to the international backslash key. Not having a physical keyboard, I cannot confirm one way or another. One snag is that there's https://keyshorts.com/blogs/blog/37615873-how-to-identify-macbook-keyboard-localization#norwegian which has both the section key (in the top left) and the internaltional tab key (to the right of left shift). I don't know what the expectation for those keys, or what they code would do for them. Not having a physical keyboard, I cannot confirm one way or another. Still, perhaps this is a better situation than before, where the key was unmapped entirely. Fixes liballeg#1523.
SiegeLord
force-pushed
the
macos_deadkeys
branch
from
a45c751 to
6b12769
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.