Improve generator.md logging #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable logging with logger_interval > 0 Default logging to stdout, and for stdout logging prepend each line with item # (file logging gets "item_<N>" appended to filename, as before).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable logging with logger_interval > 0, rather than when logger_kwargs is specified as before.
Default logging to stdout, and for stdout logging prepend each line with item # (file logging gets "item_" appended to filename, as before).
Logging test is improved by running in
tmp_path, so that existence of logging files means something. New stdout logging test, but it's broken becausepytest'scapsysfixture fails to capture theMDLoggerstdout for some reason.xfailfor now.