-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version #334
Update version #334
Conversation
How does the publishing to pip work? I can see that the wheels are built on every push, but does the publishing only happen after a tag? Has to be triggered manually? If the current main is at |
If you create a new tag (perhaps has to be of the correct format) it'll push to pypi. I'm not sure how to retroactively change the requirements for 0.2.7. Maybe create a branch from 0.2.7, change the requirement in |
Just so I'm aware, how does pushing to pypi work? |
It's done by https://github.com/libAtoms/workflow/blob/main/.github/workflows/publish_to_pypi.yml, and that has the url with the instructions we followed (and @hheenen did the pypi side). |
Looks to me, from that workflow, that any tag triggers a pypi publish. |
@gelzinyte are we ready to increment the internal version number to 0.3.1, then merge it and tag the result as 0.3.1 so pypi gets it? We can branch from 0.2.7 (maybe call the branch |
I merged from main, we'll see if that causes the tests to pass |
The last thing I wanted to fix was documentation deployment - https://libatoms.github.io/workflow/ hasn't been updated in a while. I'm not sure why |
@gelzinyte I think the |
Ah that shouldn't be there. Removed in the last commit. |
OK, tests pass. I'm going to update the version to 0.3.1, then merge, and tag the resulting |
Wrap-up version update, once #333 and #330 are merged.
Some things left to iron out:
pip install wfl==0.2.7
install ASE v3.22.1, not v3.23.0 .