-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for per-atomic-config calculator in generic.calculator. #254
Conversation
Enables autoparallelization over calculator parameters by optionally constructing per-atom calculator in autoparallelized op wfl.calculators.generic.calculate(), using Atoms.info WFL_CALCULATOR_INITIALIZER, _ARGS, and _KWARGS.
Debug of per config calculator
@Felixrccs if you are interested in using this, could I convince you to put together a pytest (could, but doesn't have to be based on a DFT calculator)? |
Yes, I can try to make a pytest. (I have no experience with that yet.) |
…ree to be used for this project.
…flow into autopara_calc_params
If you want a hand, just ask. Relevant example tests are in |
My pytest is in #261. |
This reverts commit 2bbde81.
Per configuration pytest
@Felixrccs there's an issue with the vasp test. Do you need me to debug it, or have you figured out how to run the vasp tests locally on your machine to fix it? |
@Felixrccs any progress cleaning up the vasp test? |
Sry I had some busy weeks, I try to do it tomorrow. |
Thanks - just wanted to make sure that it wasn't forgotten |
Ok I still have calculations running and don't want to change my code meanwhile, I hope I get it done on the weekend. |
… autopara_calc_params Forgot to pull before local changes
I fixed it in #265. This should work now, thank for your patience. |
Autopara calc params Dubug VASP_test
@Felixrccs thanks for all the work. I'll merge this one once the CI tests pass. Then, hopefully, we can just update and merge the universal k-point spacing functionality. |
Enables autoparallelization over calculator parameters by optionally constructing per-atom calculator in autoparallelized op wfl.calculators.generic.calculate(), using Atoms.info WFL_CALCULATOR_INITIALIZER, _ARGS, and _KWARGS.
Closes #253