-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add smoke tests for CLI #85
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoshinotsuyoshi
force-pushed
the
setup-erd-generator-cli-test-smoke
branch
from
November 13, 2024 11:39
841863b
to
456af07
Compare
hoshinotsuyoshi
changed the base branch from
main
to
feat/db-structure-to-react-flow-nodes
November 13, 2024 11:40
- Introduced `smoke.test.ts` to verify that the CLI tool can run essential commands without errors. - Includes tests for basic CLI usage and ERD command execution, checking for expected output.
hoshinotsuyoshi
force-pushed
the
setup-erd-generator-cli-test-smoke
branch
from
November 13, 2024 12:10
456af07
to
5ec7fe0
Compare
hoshinotsuyoshi
changed the title
Setup erd generator cli test smoke
Add smoke tests for CLI
Nov 13, 2024
hoshinotsuyoshi
requested review from
FunamaYukina,
junkisai,
MH4GF and
sasamuku
and removed request for
a team
November 13, 2024 12:22
MH4GF
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks 😄
I wrote a bit of comment.
Replaced `toEqual` with `toMatchInlineSnapshot` in the CLI smoke test to simplify snapshot management and improve readability of the output comparison.
MH4GF
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work 🚀
Base automatically changed from
feat/db-structure-to-react-flow-nodes
to
main
November 14, 2024 07:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add smoke tests for CLI
smoke.test.ts
to verify that the CLI tool can run essential commands without errors.Related Issue
N/A
Changes
Testing:
smoke.test.ts
underfrontend/packages/cli/src/cli/
to perform end-to-end checks on the CLI.help
command outputs the expected usage information.erd build
command runs successfully, generating the required output.Test Setup:
beforeAll
hook prepares the environment by cleaning up and building the CLI tool.node:child_process
to execute CLI commands and verifies the output usingvitest
.Testing
N/A
Other Information
N/A