Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Enhanced error rendering in the ErrorDisplay component, adding detailed error summaries #446

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

hoshinotsuyoshi
Copy link
Member

@hoshinotsuyoshi hoshinotsuyoshi commented Jan 14, 2025

Summary

Enhanced error rendering in the ErrorDisplay component, adding detailed error summaries.

  • Replaced ProcessError with ErrorObject across components and modules.
  • Fixed typos in error messages, replacing "parcing" with "parsing" in test files and logic.

Now

details-summary

Related Issue

Changes

Testing

You can check the differrence:

Other Information

@hoshinotsuyoshi hoshinotsuyoshi self-assigned this Jan 14, 2025
Copy link

changeset-bot bot commented Jan 14, 2025

🦋 Changeset detected

Latest commit: 6a34d7b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@liam-hq/erd-core Patch
@liam-hq/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hoshinotsuyoshi hoshinotsuyoshi force-pushed the error-message-parse-error-details branch from 21de3c9 to 922de3c Compare January 14, 2025 04:15
@hoshinotsuyoshi hoshinotsuyoshi changed the title draft: Error message parse error details 🚸 Enhanced error rendering in the ErrorDisplay component, adding detailed error summaries Jan 14, 2025
@hoshinotsuyoshi hoshinotsuyoshi marked this pull request as ready for review January 14, 2025 04:30
@hoshinotsuyoshi hoshinotsuyoshi requested a review from a team as a code owner January 14, 2025 04:30
@hoshinotsuyoshi hoshinotsuyoshi requested review from FunamaYukina, junkisai, MH4GF and sasamuku and removed request for a team January 14, 2025 04:30

{errors[0] && (
<div className={styles.message1Sentence}>
<details>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chose not to use <details open> to keep the display compact.

@hoshinotsuyoshi hoshinotsuyoshi marked this pull request as draft January 14, 2025 05:00
@hoshinotsuyoshi
Copy link
Member Author

The changes in 922de3c could be resolved with a smaller diff! I'll make some adjustments, so please hold on!

…iled error summaries

- Replaced `ProcessError` with `ErrorObject` across components and modules.
@hoshinotsuyoshi
Copy link
Member Author

force pushed : 🙏 922de3c -> 6a34d7b

@hoshinotsuyoshi hoshinotsuyoshi marked this pull request as ready for review January 14, 2025 05:14
Copy link
Member

@MH4GF MH4GF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@hoshinotsuyoshi hoshinotsuyoshi added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit 9dd9c28 Jan 14, 2025
13 checks passed
@hoshinotsuyoshi hoshinotsuyoshi deleted the error-message-parse-error-details branch January 14, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants