Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor workflows to include erd-web deployment #426

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

hoshinotsuyoshi
Copy link
Member

@hoshinotsuyoshi hoshinotsuyoshi commented Jan 9, 2025

Summary

Enabled apps/erd-web to deploy to the preview environment even when a PR contains changes only under packages/.

  • Renamed .github/workflows/vercel-deploy-erd-sample.yml to .github/workflows/vercel-deploy-erd.yml to encompass both erd-sample and erd-web deployments.
  • Updated filters in vercel-deploy-erd.yml to include erd-web sources.
  • Added erd-web configuration to the deployment job in vercel-deploy-erd.yml.

Related Issue

Changes

Testing

GitHub Actions in this PR are worked

  • apps/docs
  • apps/erd-web
  • apps/erd-sample

Other Information

No changeset added intentionally.

- Renamed `.github/workflows/vercel-deploy-erd-sample.yml` to `.github/workflows/vercel-deploy-erd.yml` to encompass both `erd-sample` and `erd-web` deployments.
- Updated filters in `vercel-deploy-erd.yml` to include `erd-web` sources.
- Added `erd-web` configuration to the deployment job in `vercel-deploy-erd.yml`.
@hoshinotsuyoshi hoshinotsuyoshi self-assigned this Jan 9, 2025
Copy link

changeset-bot bot commented Jan 9, 2025

⚠️ No Changeset found

Latest commit: e963ae7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment on lines 37 to 39
- './frontend/packages/cli/**'
- './frontend/packages/db-structure/**'
- './frontend/packages/erd-core/**'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabled apps/erd-web to deploy to the preview environment even when a PR contains changes only under packages/.

@hoshinotsuyoshi hoshinotsuyoshi marked this pull request as ready for review January 9, 2025 02:54
@hoshinotsuyoshi hoshinotsuyoshi requested a review from a team as a code owner January 9, 2025 02:54
@hoshinotsuyoshi hoshinotsuyoshi requested review from FunamaYukina, junkisai, MH4GF and sasamuku and removed request for a team January 9, 2025 02:54
Copy link
Member

@MH4GF MH4GF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great!! Thanks 😄

@MH4GF MH4GF added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit bee0db5 Jan 9, 2025
14 checks passed
@MH4GF MH4GF deleted the increase-erd-web-pr-preview branch January 9, 2025 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants