Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fixed problem with fitView not working properly while displaying only some tables #397

Merged
merged 1 commit into from
Dec 26, 2024
Merged

🐛 Fixed problem with fitView not working properly while displaying only some tables #397

merged 1 commit into from
Dec 26, 2024
+28 −3

Conversation

MH4GF
Copy link
Member

@MH4GF MH4GF commented Dec 26, 2024 •
edited
Loading

Reproduction Procedure

  1. Select any TableNode
  2. Click “Open in main area” under Related Tables in TableDetail 1.
  3. Click “Tidy Up”, the layout will be adjusted and fitView() will be executed, but it will be drawn at the top of the screen
demo
2024-12-26.16.21.20.mov

Cause

The transparent nonRelatedTableGroup remained and was fitViewed including its display area.

Solution

If all the nodes whose parentId is nonRelatedTableGroup node are hidden, the nonRelatedTableGroup node is also hidden.

2024-12-26.19.05.03.mov

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 26, 2024

🦋 Changeset detected

Latest commit: e0c748c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@liam-hq/erd-core Patch
@liam-hq/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MH4GF MH4GF marked this pull request as ready for review December 26, 2024 10:06
@MH4GF MH4GF requested a review from a team as a code owner December 26, 2024 10:06
@MH4GF MH4GF requested review from hoshinotsuyoshi, FunamaYukina, junkisai and sasamuku and removed request for a team December 26, 2024 10:06
junkisai
junkisai approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member

@junkisai junkisai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!!
It seems like a very good and simple solution!

@junkisai junkisai added this pull request to the merge queue Dec 26, 2024
Merged via the queue into main with commit fc6ba1d Dec 26, 2024
13 checks passed
@junkisai junkisai deleted the fix-fit-view branch December 26, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junkisai junkisai junkisai approved these changes

@hoshinotsuyoshi hoshinotsuyoshi Awaiting requested review from hoshinotsuyoshi hoshinotsuyoshi is a code owner automatically assigned from liam-hq/liam-dev

@FunamaYukina FunamaYukina Awaiting requested review from FunamaYukina FunamaYukina is a code owner automatically assigned from liam-hq/liam-dev

@sasamuku sasamuku Awaiting requested review from sasamuku sasamuku is a code owner automatically assigned from liam-hq/liam-dev

Assignees

@MH4GF MH4GF

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MH4GF @junkisai