📈 : Add open related tables log event #325
Merged
+26
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasamuku
force-pushed
the
add_open_related_tables_log_event
branch
from
ac55466 to
1fec28d
Compare
sasamuku
requested review from
hoshinotsuyoshi,
FunamaYukina,
junkisai and
MH4GF
and removed request for
a team
junkisai
reviewed
Dec 19, 2024
frontend/packages/erd-core/src/features/gtm/utils/openRelatedTablesLogEvent.ts
Outdated
Show resolved
Hide resolved
sasamuku
force-pushed
the
add_open_related_tables_log_event
branch
2 times, most recently
from
7435d27 to
a22e4a8
Compare
| tableId, | ||
| }: OpenRelatedTablesLogEvent) => { | ||
| pushToDataLayer({ | ||
| event: 'open_related_tables', |
There was a problem hiding this comment.
@junkisai
I want to know which is better 🙏
I've checked spread sheet's GTM - event column.
There was a problem hiding this comment.
@sasamuku
I apologize for the confusion. 🙏
I intended for you to reference the "dataLayer - event" column in the spreadsheet, so I would like you to use camelCase.
There was a problem hiding this comment.
@junkisai @hoshinotsuyoshi
ok!!
I've modified
9eab8e0
…ablesLogEvent.ts Co-authored-by: Junki Saito <[email protected]>
sasamuku
force-pushed
the
add_open_related_tables_log_event
branch
from
f810b2b to
9eab8e0
Compare
junkisai
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checked on Google Tag Assistant:
Related Issue
Changes
Testing
Other Information