✨ Grouping TableNodes without Relationships into a GroupNode and Applying a New Layout Definition #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and layout options for NonRelatedTableGroup nodes
junkisai
changed the title
junkisai
commented
Dec 19, 2024
Comment on lines
+30
to
+33
| const tableNodesInitialized = nodes | ||
| .filter((node) => node.type === 'table') | ||
| .some((node) => node.measured) | ||
|
|
There was a problem hiding this comment.
Before adding the Group Node, nodesInitialized would become true only when the drawing occurred after the conversion to TableNode was completed by convertDBStructureToNodes().
However, with the addition of the Group Node, nodesInitialized started to become true even before the conversion to TableNode was completed. As a result, we created our own custom nodesInitialized.
junkisai
requested review from
hoshinotsuyoshi,
FunamaYukina,
MH4GF and
sasamuku
and removed request for
a team
|
The 
|
MH4GF
reviewed
Dec 19, 2024
Comment on lines
+30
to
+33
| const tableNodesInitialized = nodes | ||
| .filter((node) => node.type === 'table') | ||
| .some((node) => node.measured) | ||
|
|
I didn't notice until you pointed it out... |
|
@junkisai |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have grouped TableNodes without Relationships into a GroupNode, allowing a new layout definition to be applied.
The new layout definition arranges the Nodes in a single vertical column.