Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: integrate highlightNodesAndEdges function for improved node and edge highlighting on hover #317

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

MH4GF
Copy link
Member

@MH4GF MH4GF commented Dec 19, 2024

Highlighting on hover is now also supported with highlightNodesAndEdges().

Blocking

Merge after the following PR merged.

Testing

  • Click on table node → Target node becomes active
  • Click on table name in LeftPane → target node becomes active
  • URL contains ?active=${tableName} → target node becomes active
  • Hover on table node → Target node becomes hovered state

@MH4GF MH4GF changed the title fix hover state refactor: integrate highlightNodesAndEdges function for improved node and edge highlighting on hover Dec 19, 2024
…s and edges in highlightNodesAndEdges function
@MH4GF MH4GF changed the title refactor: integrate highlightNodesAndEdges function for improved node and edge highlighting on hover [DO NOT MERGE] refactor: integrate highlightNodesAndEdges function for improved node and edge highlighting on hover Dec 19, 2024
@MH4GF MH4GF marked this pull request as ready for review December 19, 2024 06:34
@MH4GF MH4GF requested a review from a team as a code owner December 19, 2024 06:34
@MH4GF MH4GF requested review from hoshinotsuyoshi, FunamaYukina, junkisai and sasamuku and removed request for a team December 19, 2024 06:34
Base automatically changed from fix-active-state to main December 19, 2024 07:37
@MH4GF MH4GF changed the title [DO NOT MERGE] refactor: integrate highlightNodesAndEdges function for improved node and edge highlighting on hover refactor: integrate highlightNodesAndEdges function for improved node and edge highlighting on hover Dec 19, 2024
Copy link
Member

@FunamaYukina FunamaYukina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I learned a lot about props, triggers, and other things📝. Thank you!

@FunamaYukina FunamaYukina added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 2a981ec Dec 19, 2024
12 checks passed
@FunamaYukina FunamaYukina deleted the fix-hover-state branch December 19, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants