✨Implementing a key-only view #308
Merged
+116
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FunamaYukina
force-pushed
the
add-key-only-view
branch
from
2f415a6 to
c0934d3
Compare
FunamaYukina
commented
Dec 19, 2024
| @@ -35,26 +35,34 @@ export const TableColumn: FC<TableColumnProps> = ({ | |||
| className={styles.primaryKeyIcon} | |||
| role="img" | |||
| aria-label="Primary Key" | |||
| strokeWidth={1.5} | |||
There was a problem hiding this comment.
I've modified the strokeWidth to fit the design.
FunamaYukina
requested review from
hoshinotsuyoshi,
junkisai,
MH4GF and
sasamuku
and removed request for
a team
|
I'm going to refactor the code to reduce unnecessary use of map and filter functions.🙏 |
|
I've created a new function, commit: ab66460 @MH4GF |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
2 changes.
Preview: https://liam-erd-sample-epqkj9r9x-route-06-core.vercel.app/
1st
Implementing a key-only view
2nd
Add LinkIcon and apply it as an icon for foreign keys.
This applies not only to Key Only views but also to All Fields views.
Related Issue
Changes
Testing
Other Information