Skip to content

Commit

Permalink
Merge pull request #318 from liam-hq/remove-link-icon
Browse files Browse the repository at this point in the history
Remove LinkIcon and replace its usage with Link component
  • Loading branch information
hoshinotsuyoshi authored Dec 19, 2024
2 parents 92f8f9b + 18e5e8e commit 22af510
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 30 deletions.
7 changes: 7 additions & 0 deletions frontend/.changeset/calm-coats-smoke.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@liam-hq/erd-core": patch
"@liam-hq/ui": patch
"@liam-hq/cli": patch
---

♻️ Remove LinkIcon and replace its usage with Link component
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import type {
Cardinality as CardinalityType,
Column,
} from '@liam-hq/db-structure'
import { DiamondFillIcon, DiamondIcon, KeyRound, LinkIcon } from '@liam-hq/ui'
import { DiamondFillIcon, DiamondIcon, KeyRound, Link } from '@liam-hq/ui'
import { Handle, Position } from '@xyflow/react'
import clsx from 'clsx'
import type { FC } from 'react'
Expand Down Expand Up @@ -39,12 +39,13 @@ export const TableColumn: FC<TableColumnProps> = ({
/>
)}
{!column.primary && (isSource || targetCardinality) ? (
<LinkIcon
<Link
width={16}
height={16}
className={styles.linkIcon}
role="img"
aria-label="Foreign Key"
strokeWidth={1.5}
/>
) : !column.primary && column.notNull ? (
<DiamondFillIcon
Expand Down
26 changes: 0 additions & 26 deletions frontend/packages/ui/src/icons/LinkIcon.tsx

This file was deleted.

3 changes: 1 addition & 2 deletions frontend/packages/ui/src/icons/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ export * from './DiamondFillIcon'
export * from './Download'
export * from './Fingerprint'
export * from './GotoIcon'
export * from './LinkIcon'
export * from './Megaphone'
export * from './MessagesSquare'
export * from './Minus'
Expand All @@ -26,4 +25,4 @@ export * from './CardinalityZeroOrOneLeftIcon'
export * from './Eye'
export * from './EyeClosed'

export { KeyRound, Hash } from 'lucide-react'
export { KeyRound, Hash, Link } from 'lucide-react'

0 comments on commit 22af510

Please sign in to comment.