Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add P-line generating path cmd #77

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

ASLeonard
Copy link

I know there is not a lot of support for minigraph P-lines (#27) and it would break if a user added any new assemblies, but tools like vg deconstruct appear to perform better with path information than without. We observed ~6% more SVs (and were generally validated against assembly-based calls) when including path information than without. Arguable this may be an issue with vg rather than minigraph not providing P-lines, but that is the current state of tools.

This code is based heavily on the mgutils.js merge, except takes in a sample file and the paste *bed from stdin to create P-lines for each sample based on the paths taken during --call. I haven't really worked with js before, but I believe this is fairly streamlined.

This has a few obvious limitations.

  • minigraph call does not always yield the actual paths contributed by an assembly
  • "." alignments are basically treated as just skipping from start -> end node without any special consideration, and so are basically indistinguishable from "*" deletion alignments. (Maybe J-line would help?)

But overall we found this useful in our work (https://www.biorxiv.org/content/10.1101/2022.09.17.508368v1, page 4, some of the supplementary figures), so others may too while there is still a lot of graph <-> vcf exchange.

Best,
Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant