Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for fast mode #137

Merged
merged 10 commits into from
Nov 28, 2024
Merged

Add support for fast mode #137

merged 10 commits into from
Nov 28, 2024

Conversation

erlingrj
Copy link
Collaborator

@erlingrj erlingrj commented Nov 28, 2024 •
edited
Loading

Very simple addition, just check a flag in the wait_until function and return immediately if we are in fast mode. I dont do anything with wait_for.

Most of the diff is bringing over code from upstream LFC for handling the target property

@github-actions GitHub Actions
Copy link
Contributor

Memory usage after merging this PR will be:

Memory Report

action_empty_test_c

from to increase (%)
text 59830 59850 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 70686 70706 0.03

action_microstep_test_c

from to increase (%)
text 60667 60687 0.03
data 752 752 0.00
bss 10112 10112 0.00
total 71531 71551 0.03

action_overwrite_test_c

from to increase (%)
text 60504 60524 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 71360 71380 0.03

action_test_c

from to increase (%)
text 60440 60460 0.03
data 752 752 0.00
bss 10112 10112 0.00
total 71304 71324 0.03

delayed_conn_test_c

from to increase (%)
text 61692 61712 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 72548 72568 0.03

event_payload_pool_test_c

from to increase (%)
text 18330 18330 0.00
data 624 624 0.00
bss 320 320 0.00
total 19274 19274 0.00

event_queue_test_c

from to increase (%)
text 27597 27597 0.00
data 736 736 0.00
bss 480 480 0.00
total 28813 28813 0.00

nanopb_test_c

from to increase (%)
text 42888 42888 0.00
data 904 904 0.00
bss 320 320 0.00
total 44112 44112 0.00

port_test_c

from to increase (%)
text 61640 61660 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 72496 72516 0.03

reaction_queue_test_c

from to increase (%)
text 27277 27277 0.00
data 736 736 0.00
bss 480 480 0.00
total 28493 28493 0.00

request_shutdown_test_c

from to increase (%)
text 60639 60659 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 71495 71515 0.03

startup_test_c

from to increase (%)
text 55983 56010 0.05
data 752 752 0.00
bss 10752 10752 0.00
total 67487 67514 0.04

tcp_channel_test_c

from to increase (%)
text 60294 60294 0.00
data 1176 1176 0.00
bss 11136 11136 0.00
total 72606 72606 0.00

timer_test_c

from to increase (%)
text 55881 55901 0.04
data 744 744 0.00
bss 10752 10752 0.00
total 67377 67397 0.03

@github-actions GitHub Actions
Copy link
Contributor

Memory usage after merging this PR will be:

Memory Report

action_empty_test_c

from to increase (%)
text 59830 59850 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 70686 70706 0.03

action_microstep_test_c

from to increase (%)
text 60667 60687 0.03
data 752 752 0.00
bss 10112 10112 0.00
total 71531 71551 0.03

action_overwrite_test_c

from to increase (%)
text 60504 60524 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 71360 71380 0.03

action_test_c

from to increase (%)
text 60440 60460 0.03
data 752 752 0.00
bss 10112 10112 0.00
total 71304 71324 0.03

delayed_conn_test_c

from to increase (%)
text 61692 61712 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 72548 72568 0.03

event_payload_pool_test_c

from to increase (%)
text 18330 18330 0.00
data 624 624 0.00
bss 320 320 0.00
total 19274 19274 0.00

event_queue_test_c

from to increase (%)
text 27597 27597 0.00
data 736 736 0.00
bss 480 480 0.00
total 28813 28813 0.00

nanopb_test_c

from to increase (%)
text 42888 42888 0.00
data 904 904 0.00
bss 320 320 0.00
total 44112 44112 0.00

port_test_c

from to increase (%)
text 61640 61660 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 72496 72516 0.03

reaction_queue_test_c

from to increase (%)
text 27277 27277 0.00
data 736 736 0.00
bss 480 480 0.00
total 28493 28493 0.00

request_shutdown_test_c

from to increase (%)
text 60639 60659 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 71495 71515 0.03

startup_test_c

from to increase (%)
text 55983 56010 0.05
data 752 752 0.00
bss 10752 10752 0.00
total 67487 67514 0.04

tcp_channel_test_c

from to increase (%)
text 60294 60294 0.00
data 1176 1176 0.00
bss 11136 11136 0.00
total 72606 72606 0.00

timer_test_c

from to increase (%)
text 55881 55901 0.04
data 744 744 0.00
bss 10752 10752 0.00
total 67377 67397 0.03

@github-actions GitHub Actions
Copy link
Contributor

Memory usage after merging this PR will be:

Memory Report

action_empty_test_c

from to increase (%)
text 59830 59850 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 70686 70706 0.03

action_microstep_test_c

from to increase (%)
text 60667 60687 0.03
data 752 752 0.00
bss 10112 10112 0.00
total 71531 71551 0.03

action_overwrite_test_c

from to increase (%)
text 60504 60524 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 71360 71380 0.03

action_test_c

from to increase (%)
text 60440 60460 0.03
data 752 752 0.00
bss 10112 10112 0.00
total 71304 71324 0.03

delayed_conn_test_c

from to increase (%)
text 61692 61712 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 72548 72568 0.03

event_payload_pool_test_c

from to increase (%)
text 18330 18330 0.00
data 624 624 0.00
bss 320 320 0.00
total 19274 19274 0.00

event_queue_test_c

from to increase (%)
text 27597 27597 0.00
data 736 736 0.00
bss 480 480 0.00
total 28813 28813 0.00

nanopb_test_c

from to increase (%)
text 42888 42888 0.00
data 904 904 0.00
bss 320 320 0.00
total 44112 44112 0.00

port_test_c

from to increase (%)
text 61640 61660 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 72496 72516 0.03

reaction_queue_test_c

from to increase (%)
text 27277 27277 0.00
data 736 736 0.00
bss 480 480 0.00
total 28493 28493 0.00

request_shutdown_test_c

from to increase (%)
text 60639 60659 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 71495 71515 0.03

startup_test_c

from to increase (%)
text 55983 56010 0.05
data 752 752 0.00
bss 10752 10752 0.00
total 67487 67514 0.04

tcp_channel_test_c

from to increase (%)
text 60294 60294 0.00
data 1176 1176 0.00
bss 11136 11136 0.00
total 72606 72606 0.00

timer_test_c

from to increase (%)
text 55881 55901 0.04
data 744 744 0.00
bss 10752 10752 0.00
total 67377 67397 0.03

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

Memory usage after merging this PR will be:

Memory Report

action_empty_test_c

from to increase (%)
text 59830 59850 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 70686 70706 0.03

action_microstep_test_c

from to increase (%)
text 60667 60687 0.03
data 752 752 0.00
bss 10112 10112 0.00
total 71531 71551 0.03

action_overwrite_test_c

from to increase (%)
text 60504 60524 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 71360 71380 0.03

action_test_c

from to increase (%)
text 60440 60460 0.03
data 752 752 0.00
bss 10112 10112 0.00
total 71304 71324 0.03

delayed_conn_test_c

from to increase (%)
text 61692 61712 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 72548 72568 0.03

event_payload_pool_test_c

from to increase (%)
text 18330 18330 0.00
data 624 624 0.00
bss 320 320 0.00
total 19274 19274 0.00

event_queue_test_c

from to increase (%)
text 27597 27597 0.00
data 736 736 0.00
bss 480 480 0.00
total 28813 28813 0.00

nanopb_test_c

from to increase (%)
text 42888 42888 0.00
data 904 904 0.00
bss 320 320 0.00
total 44112 44112 0.00

port_test_c

from to increase (%)
text 61640 61660 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 72496 72516 0.03

reaction_queue_test_c

from to increase (%)
text 27277 27277 0.00
data 736 736 0.00
bss 480 480 0.00
total 28493 28493 0.00

request_shutdown_test_c

from to increase (%)
text 60639 60659 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 71495 71515 0.03

startup_test_c

from to increase (%)
text 55983 56010 0.05
data 752 752 0.00
bss 10752 10752 0.00
total 67487 67514 0.04

tcp_channel_test_c

from to increase (%)
text 60294 60294 0.00
data 1176 1176 0.00
bss 11136 11136 0.00
total 72606 72606 0.00

timer_test_c

from to increase (%)
text 55881 55901 0.04
data 744 744 0.00
bss 10752 10752 0.00
total 67377 67397 0.03

@github-actions GitHub Actions
Copy link
Contributor

Memory usage after merging this PR will be:

Memory Report

action_empty_test_c

from to increase (%)
text 59830 59850 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 70686 70706 0.03

action_microstep_test_c

from to increase (%)
text 60667 60687 0.03
data 752 752 0.00
bss 10112 10112 0.00
total 71531 71551 0.03

action_overwrite_test_c

from to increase (%)
text 60504 60524 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 71360 71380 0.03

action_test_c

from to increase (%)
text 60440 60460 0.03
data 752 752 0.00
bss 10112 10112 0.00
total 71304 71324 0.03

delayed_conn_test_c

from to increase (%)
text 61692 61712 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 72548 72568 0.03

event_payload_pool_test_c

from to increase (%)
text 18330 18330 0.00
data 624 624 0.00
bss 320 320 0.00
total 19274 19274 0.00

event_queue_test_c

from to increase (%)
text 27597 27597 0.00
data 736 736 0.00
bss 480 480 0.00
total 28813 28813 0.00

nanopb_test_c

from to increase (%)
text 42888 42888 0.00
data 904 904 0.00
bss 320 320 0.00
total 44112 44112 0.00

port_test_c

from to increase (%)
text 61640 61660 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 72496 72516 0.03

reaction_queue_test_c

from to increase (%)
text 27277 27277 0.00
data 736 736 0.00
bss 480 480 0.00
total 28493 28493 0.00

request_shutdown_test_c

from to increase (%)
text 60639 60659 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 71495 71515 0.03

startup_test_c

from to increase (%)
text 55983 56010 0.05
data 752 752 0.00
bss 10752 10752 0.00
total 67487 67514 0.04

tcp_channel_test_c

from to increase (%)
text 60294 60294 0.00
data 1176 1176 0.00
bss 11136 11136 0.00
total 72606 72606 0.00

timer_test_c

from to increase (%)
text 55881 55901 0.04
data 744 744 0.00
bss 10752 10752 0.00
total 67377 67397 0.03

@erlingrj erlingrj mentioned this pull request Nov 28, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

Memory usage after merging this PR will be:

Memory Report

action_empty_test_c

from to increase (%)
text 59830 59850 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 70686 70706 0.03

action_microstep_test_c

from to increase (%)
text 60667 60687 0.03
data 752 752 0.00
bss 10112 10112 0.00
total 71531 71551 0.03

action_overwrite_test_c

from to increase (%)
text 60504 60524 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 71360 71380 0.03

action_test_c

from to increase (%)
text 60440 60460 0.03
data 752 752 0.00
bss 10112 10112 0.00
total 71304 71324 0.03

delayed_conn_test_c

from to increase (%)
text 61692 61712 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 72548 72568 0.03

event_payload_pool_test_c

from to increase (%)
text 18330 18330 0.00
data 624 624 0.00
bss 320 320 0.00
total 19274 19274 0.00

event_queue_test_c

from to increase (%)
text 27597 27597 0.00
data 736 736 0.00
bss 480 480 0.00
total 28813 28813 0.00

nanopb_test_c

from to increase (%)
text 42888 42888 0.00
data 904 904 0.00
bss 320 320 0.00
total 44112 44112 0.00

port_test_c

from to increase (%)
text 61640 61660 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 72496 72516 0.03

reaction_queue_test_c

from to increase (%)
text 27277 27277 0.00
data 736 736 0.00
bss 480 480 0.00
total 28493 28493 0.00

request_shutdown_test_c

from to increase (%)
text 60639 60659 0.03
data 744 744 0.00
bss 10112 10112 0.00
total 71495 71515 0.03

startup_test_c

from to increase (%)
text 55983 56010 0.05
data 752 752 0.00
bss 10752 10752 0.00
total 67487 67514 0.04

tcp_channel_test_c

from to increase (%)
text 60294 60294 0.00
data 1176 1176 0.00
bss 11136 11136 0.00
total 72606 72606 0.00

timer_test_c

from to increase (%)
text 55881 55901 0.04
data 744 744 0.00
bss 10752 10752 0.00
total 67377 67397 0.03

@github-actions GitHub Actions
Copy link
Contributor

Coverage after merging fast-mode into main will be

67.75%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   action.c81.90%69.23%100%85.33%120–121, 24, 43–46, 49, 51, 53, 56–58, 63–64, 73–74, 85–86
   builtin_triggers.c90.91%70%100%96.77%14, 18, 40, 43
   connection.c78.52%51.16%100%88.66%10, 104, 11, 110, 123–124, 136–137, 14, 14, 143, 145, 16–17, 21–22, 22, 22–23, 25, 27–28, 33, 48, 48, 48–49, 55, 60–62, 97
   environment.c78.35%55.56%84.62%83.33%12–13, 18, 20–21, 31, 35–36, 42–43, 51–52, 55–56, 60–61, 93–95
   event.c95.35%92.86%100%96.15%14–15
   federated.c0%0%0%0%100–101, 103–106, 108, 108, 108–109, 11, 110–111, 113, 115–116, 116, 116, 116–119, 12, 120, 122–123, 126, 129–130, 130, 130–131, 133–134, 136, 14, 140–141, 143–145, 148, 150–155, 157–159, 16, 16, 16, 162–164, 164, 164–165, 165, 165–167, 169, 17, 172–173, 175–179, 18, 181–186, 188, 188, 188–189, 19, 190–191, 193, 193, 193–195, 195, 195–196, 20, 200–201, 201, 201, 204–205, 209, 21, 21, 21, 210–211, 213, 213, 213, 215–219, 22, 222, 222, 222–225, 228–229, 229, 229–230, 232–233, 236–237, 242–243, 243, 243–244, 246, 248, 248, 248–249, 25, 250–251, 251, 251, 251, 251–259, 26, 260–263, 267, 27, 27, 27, 270, 270, 270–272, 276, 279, 28, 280, 280, 280, 280–288, 29, 29, 29, 290, 292–294, 294, 294–295, 297, 297, 297–299, 30, 301–303, 305, 307, 31, 311, 311, 311–312, 312, 312–313, 313, 313–319, 32, 32, 32, 320–324, 326–327, 33, 330–333, 335, 335, 335–336, 34, 34, 34, 34, 340–341, 341, 341, 343, 345–346, 346, 346–347, 347, 347–348, 348, 348–349, 349, 349, 35, 350, 350, 350–351, 351, 351, 353, 353, 353–354, 354, 354–355, 355, 355–356, 356, 356, 358, 36–39, 41, 41, 41, 41, 41–42, 44–47, 52, 52, 52, 52, 52–53, 56, 60–61, 63–66, 68, 68, 68–69, 69, 69, 71, 71, 71–73, 73, 73–75, 79–80, 84–85, 87–90, 92, 94, 94, 94–95, 95, 95–96, 96, 96–97, 97, 97
   logging.c73.21%60%100%75%24, 24–27, 37–39, 46, 46–49, 59–60
   port.c81.43%50%100%95.45%10, 10, 10, 16, 20, 26, 26–28, 38, 38, 38–39
   queues.c89.94%80.36%100%94.06%108, 113, 119, 21–23, 47–48, 60–61, 84–88, 91–92
   reaction.c69.83%54.55%100%77.61%15, 17, 21–22, 28–31, 31, 31–32, 42, 45, 47, 52–53, 53, 53–55, 55, 55–56, 73, 89–91, 91, 91–94, 94, 94–95
   reactor.c69.33%51.52%100%82.28%10, 101–102, 14–19, 22, 28, 30, 32–37, 37, 37–38, 38, 38, 43, 55, 58–59, 59, 59–60, 60, 60–61, 63, 77–78, 81–82, 82, 82–83, 83, 83–84, 86, 91
   serialization.c50%50%50%50%16–17, 26–27, 33–35, 38–40
   tag.c40.19%31.48%60%47.92%14, 14–15, 17, 17–18, 23–24, 24, 24, 24, 24–25, 27, 27, 27, 27, 27–28, 30, 30, 30–31, 33–34, 34, 34–35, 37, 37, 37, 37, 37–38, 40, 40, 40, 40, 40–41, 43, 53–54, 63, 63–64, 83–85, 85, 85, 85, 85, 85, 85, 85, 85, 85, 85–87, 89
   timer.c95%66.67%100%100%14, 25
   trigger.c100%100%100%100%
   util.c0%0%0%0%10, 3–4, 4, 4–5, 5, 5–6, 8–9
src/platform/posix
   posix.c52.73%30%66.67%56%100, 100, 100–102, 106, 16, 18, 20–21, 34–36, 38–40, 48–49, 54–59, 59, 59–62, 62, 62–64, 67, 73–74, 78, 81, 92–94, 94, 94–96, 98–99
   tcp_ip_channel.c67.52%56.69%94.12%70.73%114–116, 121–123, 127–129, 149, 153, 153, 153, 157–158, 171–172, 175–176, 178, 178, 178, 180–181, 183–184, 191–192, 194, 197, 212–213, 217–219, 221, 226–229, 232, 235, 238, 245–248, 250, 250, 250–252, 254–257, 260–261, 291–293, 300, 305–307, 307, 307–308, 310–313, 32, 322, 322–324, 33, 346–349, 349, 349–351, 361–362, 362, 362–363, 363, 363–364, 368–369, 372, 382–383, 400–401, 405–406, 41–42, 420, 422, 428–429,

@erlingrj erlingrj merged commit 86c9fad into main Nov 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanneberger tanneberger Awaiting requested review from tanneberger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@erlingrj