Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the NP scheduler when deadlines are present #2442

Merged
merged 2 commits into from
Nov 30, 2024
Merged

Use the NP scheduler when deadlines are present #2442

merged 2 commits into from
Nov 30, 2024

Conversation

lsk567
Copy link
Collaborator

@lsk567 lsk567 commented Nov 29, 2024

This PR removes pickScheduler() in the C generator that picks the GEDF scheduler when deadlines are present. As Pipeline.lf exposes, the GEDF scheduler does not take advantage of the program's parallelism, making it more likely to cause deadline misses.

Instead, the NP scheduler is now used at all times unless other schedulers are explicitly specified.

@lsk567 lsk567 added the enhancement Enhancement of existing feature label Nov 29, 2024
Copy link
Collaborator

@erlingrj erlingrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lsk567 lsk567 added this pull request to the merge queue Nov 30, 2024
Merged via the queue into master with commit 800679b Nov 30, 2024
24 checks passed
@lsk567 lsk567 deleted the default-np branch November 30, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants