Stop removing GCC on MacOS in CI #2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petervdonovan
added
ci
This is what happens in CI: > Run sudo rm -f $(which gcc) rm: /usr/bin/gcc: Read-only file system This seems to indicate that there is no way to move or delete the GCC binary, and it will not work to change the PATH to not include /usr/bin because that will break a lot of things. Therefore, there probably is no easy way to make GCC invisible on the system, so if we want a quick fix, then we should give up exercising that code path in CI. The code path under test is already difficult to maintain anyway and works on a "best effort" basis.
|
My latest commit message explains why I decided to give up on this aspect of the workflow run. I can try harder if we think it is important to do so. |
petervdonovan
changed the title
lhstrh
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LSP tests are error prone because they test interactions with external tools. They broke because correct behavior depends on how the external tools are made available on the system.
A robust solution would involve either removing the feature that the LSP tests are designed to test, or dockerizing the LSP tests. However, this PR provides a quick stopgap solution instead so that we can avoid having to force an immediate long-term decision.