-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Target Description web page #298
base: main
Are you sure you want to change the base?
Conversation
chanijjani
commented
Nov 20, 2024
•
edited
Loading
edited
- Update the Rust target document parts regarding to Check validity of target property descriptions #276
b57e61e
to
6dd85da
Compare
6dd85da
to
4b5a2bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do the curly brackets do?
- Update the Rust target document parts. Signed-off-by: Chanhee Lee <[email protected]>
4b5a2bb
to
02c6045
Compare
I intended to leave the parts as backups but just dropped them for clarification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for these changes, @chanijjani!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, there is one thing missing here. These changes should also be reflected in the versioned docs. Could you add those to this PR as well?
Rust target description validation
|
Signed-off-by: Chanhee Lee <[email protected]>
@lhstrh Would the above table be enough for the versioned documents? Or could you let me share a guide for the documents? |
I'm not sure what you mean, @chanijjani, but what I'm asking for is to simply replicate the changes you made in this PR across the files in the |
@lhstrh Oh, I understand. Let me do that immediately. |
Signed-off-by: Chanhee Lee <[email protected]>