Patmos docs updated to reflect lf-lang/lingua-franca#2383 #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR that needs to get merged before these docs are relevant is seems to be lf-lang/lingua-franca#2383. |
EhsanKhodadad
changed the title
lhstrh
reviewed
Oct 28, 2024
There was a problem hiding this comment.
I'm not a user of the Patmos platform, so it's hard for me to review these docs. Maybe @schoeberl can help? Having to create a Makefile among the generated sources strikes me as problematic... The whole build workflow is based on CMake, and this seems to bypass that completely. Why? @erlingrj has worked on platform support prior to this, so let me tag him here as well.
lhstrh
reviewed
Oct 28, 2024
lhstrh
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See lf-lang/reactor-c#383, which is yet to be completed and merged.