Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated compiler and compiler-flags property, removed cmake property #242

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

cmnrd
Copy link
Contributor

@cmnrd cmnrd commented Mar 6, 2024

  • the cmake property was removed a while ago, this PR removes it from the docs
  • update the description of the compiler property to account for the removal of cmake and align with the C++ description.
  • the flags property was renamed to compiler-flags, this PR updated the documentation accordingly

@cmnrd cmnrd requested review from lhstrh and edwardalee March 6, 2024 13:00
@cmnrd cmnrd force-pushed the fix-compiler branch 2 times, most recently from 27f2bb6 to 2a2d592 Compare March 6, 2024 13:20
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmnrd cmnrd merged commit 0e0c425 into main Mar 7, 2024
1 check passed
@cmnrd cmnrd deleted the fix-compiler branch March 7, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants