Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated favicon #152

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Updated favicon #152

merged 1 commit into from
Aug 28, 2023

Conversation

lhstrh
Copy link
Member

@lhstrh lhstrh commented Aug 28, 2023

Gatsby produces a favicon based on the PNG referenced in the configuration. This image has been updated because the gradient was in the wrong direction. The old icon, as well as the superfluous favicon.ico were removed.

@lhstrh lhstrh force-pushed the favicon branch 2 times, most recently from e4ab9a7 to d967b1f Compare August 28, 2023 20:48
@lhstrh lhstrh requested a review from axmmisaka August 28, 2023 22:21
Copy link
Collaborator

@axmmisaka axmmisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but is there an SVG version? We have a bunch of svg version logos already under ./img/ If so maybe we use that instead (png will get blurry when favicon gets enlarged), if not I think this is good.

@lhstrh
Copy link
Member Author

lhstrh commented Aug 28, 2023

I tried that, but then Gatsby complained about exceeding pixel height, which is strange because SVGs have no pixels...

@lhstrh lhstrh merged commit 252f965 into main Aug 28, 2023
1 check passed
@lhstrh lhstrh deleted the favicon branch August 28, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants