Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virtualization workflow with no TPM #1025

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

milan-zededa
Copy link
Contributor

We want to test deploying container-in-VM to a device without TPM. In the past we had some bug merged because this was not tested. Also, it is better to use string attributes for workflow matrix, even for the boolean tpm option.

Then instead of workflow names:

eden-report-smoke.tests.txt-tpm-true-ext4
eden-report-smoke.tests.txt-tpm-false-zfs

We get somewhat more readable:

eden-report-smoke.tests.txt-tpm-ext4
eden-report-smoke.tests.txt-no-tpm-zfs

I'm open for one-word suggestions to replace "no-tpm". What EVE uses when TPM is not available? Golang crypto library? Should we call it "gocrypto"? I don't know.

We want to test deploying container-in-VM to a device without TPM.
In the past we had some bug merged because this was not tested.
Also, it is better to use string attributes for workflow matrix,
even for the boolean tpm option.

Then instead of workflow names:

eden-report-smoke.tests.txt-tpm-true-ext4
eden-report-smoke.tests.txt-tpm-false-zfs

We get somewhat more readable

eden-report-smoke.tests.txt-tpm-ext4
eden-report-smoke.tests.txt-no-tpm-zfs

I'm open for one-word suggestions to replace "no-tpm".
What EVE uses when TPM is not available? Golang crypto library?
Should we call it gocrypto? I don't know.

Signed-off-by: Milan Lenco <[email protected]>
@milan-zededa
Copy link
Contributor Author

Names of artifacts are not what I have hoped for, moving to draft..

@milan-zededa milan-zededa marked this pull request as draft September 16, 2024 09:45
@shjala
Copy link
Member

shjala commented Oct 9, 2024

What EVE uses when TPM is not available? Golang crypto library? Should we call it "gocrypto"? I don't know.

TPM is used to store some private keys (device key, encryption key) and vault AES key, TPM is very slow and we are not using TPM for crypto operation (we do, but only in one case and that is encrypt/decrypt vault backup key that comes from the cloud and that happens very infrequently). If no TPM available, the aforementioned keys are stored as plain text and vault encryption is disabled.

I think tpm and no-tpm is descriptive enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants