Make Session.cookies a property, use session._cookies for Cookies object #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to replace session.cookies after initialization with any CookieTypes object. This behavior matches httpx and requests, and allows it to be a drop-in replacement even in less typical usecases. httpx uses property in the same manner: https://github.com/encode/httpx/blob/47f4a96/httpx/_client.py#L317-L326 requests appears to differ at first glance, as it does not use a property, but each request calls merge_cookies, which converts dicts to cookie jars, so it's virtually identical https://github.com/psf/requests/blob/23540c9/src/requests/sessions.py#L241 https://github.com/psf/requests/blob/23540c9/src/requests/cookies.py#L552-L553
|
Do you have a example usage of the new behavior? |
from curl_cffi import requests
from http.cookiejar import MozillaCookieJar
session = requests.Session()
cookies = MozillaCookieJar('blabla.txt')
cookies.load()
session.cookies = cookiesThis is a basic example, usually Session gets initialised in a parent class, which makes overriding like this necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to replace session.cookies after initialization with any CookieTypes object. This behavior matches httpx and requests, and allows it to be a drop-in replacement even in less typical usecases.
httpx uses property in the same manner:
https://github.com/encode/httpx/blob/47f4a96ffaaaa07dca1614409549b5d7a6e7af49/httpx/_client.py#L317-L326
requests appears to differ at first glance, as it does not use a property, but each request calls merge_cookies, which converts dicts to cookie jars, so it's virtually identical
https://github.com/psf/requests/blob/23540c93cac97c763fe59e843a08fa2825aa80fd/src/requests/sessions.py#L241
https://github.com/psf/requests/blob/23540c93cac97c763fe59e843a08fa2825aa80fd/src/requests/cookies.py#L552-L553