Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mypy + Ruff #269

Merged
merged 13 commits into from
Mar 17, 2024
Merged

Mypy + Ruff #269

merged 13 commits into from
Mar 17, 2024

Conversation

deedy5
Copy link
Contributor

@deedy5 deedy5 commented Mar 9, 2024 •
edited
Loading

Mypy check + Ruff lint + Ruff format.

New commands in Makefile:

  1. make lint:
    а) Ruff linter checking,
    b) Ruff formatter checking,
    c) Mypy type checking;
  2. make format:
    a) Ruff linter fix,
    b) Ruff formatter fix.

@perklet
Copy link
Collaborator

perklet commented Mar 9, 2024

Cool, I have wanted to do this for a long time, but didn’t have the bandwidth.

@deedy5 deedy5 force-pushed the mypy branch 7 times, most recently from a965178 to 16c19d1 Compare March 9, 2024 11:32
@deedy5
Mypy: fix and update typing annotations
284b747 
Ruff: format all files
py.typed: create file
Makefile: add `make format` - type check with Mypy
Makefile: add `make lint` - lint and format check with Ruff
Github actions: make lint before build
@deedy5
Copy link
Contributor Author

deedy5 commented Mar 9, 2024

@yifeikong Done

T-256
T-256 reviewed Mar 9, 2024
View reviewed changes
Copy link
Contributor

@T-256 T-256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks You!

.github/workflows/build-and-test.yaml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
tests/threads/test_eventlet.py Show resolved Hide resolved
deedy5 and others added 3 commits March 9, 2024 20:28
@deedy5
Github actions: make lint once
9041364
@deedy5 @T-256
Update Makefile
d8cb449 
`make lint`: а) Ruff linter checking, b) Ruff formatter checking, c) Mypy type checking;
`make format`: a) Ruff linter fix, b) Ruff formatter fix.

Co-authored-by: T-256 <[email protected]>
@deedy5
[tool.ruff]: remove target-version, prefer project.requires-python
7a914ef
T-256
T-256 approved these changes Mar 9, 2024
View reviewed changes
Copy link
Contributor

@T-256 T-256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@deedy5
Copy link
Contributor Author

deedy5 commented Mar 10, 2024

We can make strict = true in project.toml, but we'll have to do a lot more work.

perklet
perklet reviewed Mar 16, 2024
View reviewed changes
curl_cffi/aio.py Outdated Show resolved Hide resolved
@deedy5 deedy5 force-pushed the mypy branch 2 times, most recently from c6deb61 to c1e71bf Compare March 16, 2024 20:47
@deedy5
Copy link
Contributor Author

deedy5 commented Mar 16, 2024

@yifeikong 🏁

@perklet perklet merged commit 0ba3277 into lexiforest:main Mar 17, 2024
7 checks passed
@deedy5 deedy5 deleted the mypy branch March 20, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perklet perklet perklet left review comments

@T-256 T-256 T-256 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deedy5 @perklet @T-256