Add Cookie to dict #231

Ausli · 2024-01-31T14:46:38Z

No description provided.

perklet · 2024-01-31T14:52:28Z

Actually, you can do this:

c = dict(session.cookies)

Ausli · 2024-01-31T14:58:03Z

Yes, it's optional, and I thought it would be more convenient to add it, since the requests library has this function as well

perklet · 2024-01-31T16:29:59Z

OK, it makes sense to me.

perklet

Also add a simple unittest for this function.

curl_cffi/requests/cookies.py

Co-authored-by: Yifei Kong <[email protected]>

Ausli · 2024-02-03T10:17:12Z

Is there a unit test template for the project, lend me for reference.

perklet · 2024-02-05T06:14:47Z

Sorry, there is no such templates, you can take this as a reference.

Ausli · 2024-02-14T09:34:16Z

I get the following error when I run the test_cookies.py file
ModuleNotFoundError: No module named 'curl_cffi._wrapper'
How should I get _wrapper.so

perklet · 2024-02-15T02:18:23Z

I get the following error when I run the test_cookies.py file ModuleNotFoundError: No module named 'curl_cffi._wrapper' How should I get _wrapper.so

pip install -e .

Ausli · 2024-02-15T03:09:56Z

G:\workarea\MyProject\pythonProject\curl_cffi\ffi\shim.h(5): fatal error C1083: �޷��򿪰��ļ�: ��curl/curl.h��: No such file or directory
The compile path is messed up, see what's wrong with it
I suspect the reason is that the program reads the file using GBK encoding, but the file is UTF8 encoded causing the problem

Ausli · 2024-02-17T11:05:04Z

(pythonProject) PS G:\workarea\MyProject\pythonProject\curl_cffi> pip install -e .
Obtaining file:///G:/workarea/MyProject/pythonProject/curl_cffi
  Installing build dependencies ... done
  Checking if build backend supports build_editable ... done
  Getting requirements to build editable ... error
  error: subprocess-exited-with-error
  
  × Getting requirements to build editable did not run successfully.
  │ exit code: 1
  ╰─> [42 lines of output]
      Traceback (most recent call last):
        File "G:\Env\installer\miniconda\envs\pythonProject\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 353, in <module>
          main()
        File "G:\Env\installer\miniconda\envs\pythonProject\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "G:\Env\installer\miniconda\envs\pythonProject\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 132, in get_requires_for_build_editable
          return hook(config_settings)
                 ^^^^^^^^^^^^^^^^^^^^^
        File "C:\Users\a5320\AppData\Local\Temp\pip-build-env-gdxz1ugr\overlay\Lib\site-packages\setuptools\build_meta.py", line 441, in get_requires_for_build_editable
          return self.get_requires_for_build_wheel(config_settings)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "C:\Users\a5320\AppData\Local\Temp\pip-build-env-gdxz1ugr\overlay\Lib\site-packages\setuptools\build_meta.py", line 325, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=['wheel'])
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "C:\Users\a5320\AppData\Local\Temp\pip-build-env-gdxz1ugr\overlay\Lib\site-packages\setuptools\build_meta.py", line 295, in _get_build_requires
          self.run_setup()
        File "C:\Users\a5320\AppData\Local\Temp\pip-build-env-gdxz1ugr\overlay\Lib\site-packages\setuptools\build_meta.py", line 311, in run_setup
          exec(code, locals())
        File "<string>", line 16, in <module>
        File "C:\Users\a5320\AppData\Local\Temp\pip-build-env-gdxz1ugr\overlay\Lib\site-packages\setuptools\__init__.py", line 103, in setup
          return distutils.core.setup(**attrs)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "C:\Users\a5320\AppData\Local\Temp\pip-build-env-gdxz1ugr\overlay\Lib\site-packages\setuptools\_distutils\core.py", line 147, in setup
          _setup_distribution = dist = klass(attrs)
                                       ^^^^^^^^^^^^
        File "C:\Users\a5320\AppData\Local\Temp\pip-build-env-gdxz1ugr\overlay\Lib\site-packages\setuptools\dist.py", line 303, in __init__
          _Distribution.__init__(self, dist_attrs)
        File "C:\Users\a5320\AppData\Local\Temp\pip-build-env-gdxz1ugr\overlay\Lib\site-packages\setuptools\_distutils\dist.py", line 283, in __init__
          self.finalize_options()
        File "C:\Users\a5320\AppData\Local\Temp\pip-build-env-gdxz1ugr\overlay\Lib\site-packages\setuptools\dist.py", line 654, in finalize_options
          ep(self)
        File "C:\Users\a5320\AppData\Local\Temp\pip-build-env-gdxz1ugr\overlay\Lib\site-packages\setuptools\dist.py", line 674, in _finalize_setup_keywords
          ep.load()(self, ep.name, value)
        File "C:\Users\a5320\AppData\Local\Temp\pip-build-env-gdxz1ugr\overlay\Lib\site-packages\cffi\setuptools_ext.py", line 216, in cffi_modules
          add_cffi_module(dist, cffi_module)
        File "C:\Users\a5320\AppData\Local\Temp\pip-build-env-gdxz1ugr\overlay\Lib\site-packages\cffi\setuptools_ext.py", line 49, in add_cffi_module
          execfile(build_file_name, mod_vars)
        File "C:\Users\a5320\AppData\Local\Temp\pip-build-env-gdxz1ugr\overlay\Lib\site-packages\cffi\setuptools_ext.py", line 22, in execfile
          src = f.read()
                ^^^^^^^^
      UnicodeDecodeError: 'gbk' codec can't decode byte 0xa3 in position 1488: illegal multibyte sequence
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build editable did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

(curl) PS G:\workarea\MyProject\curl_cffi> pip install  .  
Looking in indexes: https://pypi.tuna.tsinghua.edu.cn/simple
Processing g:\workarea\myproject\curl_cffi
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Requirement already satisfied: cffi>=1.12.0 in g:\env\installer\miniconda\envs\curl\lib\site-packages (from curl_cffi==0.6.0b9) (1.16.0)
Requirement already satisfied: certifi in g:\env\installer\miniconda\envs\curl\lib\site-packages (from curl_cffi==0.6.0b9) (2024.2.2)
Requirement already satisfied: pycparser in g:\env\installer\miniconda\envs\curl\lib\site-packages (from cffi>=1.12.0->curl_cffi==0.6.0b9) (2.21)
Building wheels for collected packages: curl_cffi
  Building wheel for curl_cffi (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Building wheel for curl_cffi (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [46 lines of output]
      .so files alreay downloaded.
      running bdist_wheel
      running build
      running build_py
      creating build
      creating build\lib.win-amd64-cpython-38
      creating build\lib.win-amd64-cpython-38\curl_cffi
      copying curl_cffi\aio.py -> build\lib.win-amd64-cpython-38\curl_cffi
      copying curl_cffi\const.py -> build\lib.win-amd64-cpython-38\curl_cffi
      copying curl_cffi\curl.py -> build\lib.win-amd64-cpython-38\curl_cffi
      copying curl_cffi\_asyncio_selector.py -> build\lib.win-amd64-cpython-38\curl_cffi
      copying curl_cffi\__init__.py -> build\lib.win-amd64-cpython-38\curl_cffi
      copying curl_cffi\__version__.py -> build\lib.win-amd64-cpython-38\curl_cffi
      creating build\lib.win-amd64-cpython-38\curl_cffi\requests
      copying curl_cffi\requests\cookies.py -> build\lib.win-amd64-cpython-38\curl_cffi\requests
      copying curl_cffi\requests\errors.py -> build\lib.win-amd64-cpython-38\curl_cffi\requests
      copying curl_cffi\requests\exceptions.py -> build\lib.win-amd64-cpython-38\curl_cffi\requests
      copying curl_cffi\requests\headers.py -> build\lib.win-amd64-cpython-38\curl_cffi\requests
      copying curl_cffi\requests\models.py -> build\lib.win-amd64-cpython-38\curl_cffi\requests
      copying curl_cffi\requests\session.py -> build\lib.win-amd64-cpython-38\curl_cffi\requests
      copying curl_cffi\requests\websockets.py -> build\lib.win-amd64-cpython-38\curl_cffi\requests
      copying curl_cffi\requests\__init__.py -> build\lib.win-amd64-cpython-38\curl_cffi\requests
      running egg_info
      writing curl_cffi.egg-info\PKG-INFO
      writing dependency_links to curl_cffi.egg-info\dependency_links.txt
      writing requirements to curl_cffi.egg-info\requires.txt
      writing top-level names to curl_cffi.egg-info\top_level.txt
      reading manifest file 'curl_cffi.egg-info\SOURCES.txt'
      reading manifest template 'MANIFEST.in'
      warning: no files found matching 'include\curl\*'
      adding license file 'LICENSE'
      writing manifest file 'curl_cffi.egg-info\SOURCES.txt'
      copying curl_cffi\libcurl.dll -> build\lib.win-amd64-cpython-38\curl_cffi
      running build_ext
      generating cffi module 'build\\temp.win-amd64-cpython-38\\Release\\curl_cffi._wrapper.c'
      creating build\temp.win-amd64-cpython-38
      creating build\temp.win-amd64-cpython-38\Release
      building 'curl_cffi._wrapper' extension
      creating build\temp.win-amd64-cpython-38\Release\build
      creating build\temp.win-amd64-cpython-38\Release\build\temp.win-amd64-cpython-38
      creating build\temp.win-amd64-cpython-38\Release\build\temp.win-amd64-cpython-38\Release
      creating build\temp.win-amd64-cpython-38\Release\ffi
      D:\Software\IDE\Visual_Studio\IDE\Enterprise\VC\Tools\MSVC\14.38.33130\bin\HostX86\x64\cl.exe /c /nologo /O2 /W3 /GL /DNDEBUG /MD -Iinclude -Iffi -IG:\Env\installer\miniconda
\envs\curl\include -IG:\Env\installer\miniconda\envs\curl\Include -ID:\Software\IDE\Visual_Studio\IDE\Enterprise\VC\Tools\MSVC\14.38.33130\include -ID:\Software\IDE\Visual_Studio\I
DE\Enterprise\VC\Tools\MSVC\14.38.33130\ATLMFC\include -ID:\Software\IDE\Visual_Studio\IDE\Enterprise\VC\Auxiliary\VS\include "-ID:\Windows Kits\10\include\10.0.22621.0\ucrt" "-ID:
\Windows Kits\10\\include\10.0.22621.0\\um" "-ID:\Windows Kits\10\\include\10.0.22621.0\\shared" "-ID:\Windows Kits\10\\include\10.0.22621.0\\winrt" "-ID:\Windows Kits\10\\include\
10.0.22621.0\\cppwinrt" "-IC:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\include\um" /Tcbuild\temp.win-amd64-cpython-38\Release\curl_cffi._wrapper.c /Fobuild\temp.win-amd64-cpython-38\Release\build\temp.win-amd64-cpython-38\Release\curl_cffi._wrapper.obj
      curl_cffi._wrapper.c
      ffi\shim.h(5): fatal error C1083: 无法打开包括文件: “curl/curl.h”: No such file or directory
      error: command 'D:\\Software\\IDE\\Visual_Studio\\IDE\\Enterprise\\VC\\Tools\\MSVC\\14.38.33130\\bin\\HostX86\\x64\\cl.exe' failed with exit code 2
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for curl_cffi
Failed to build curl_cffi
ERROR: Could not build wheels for curl_cffi, which is required to install pyproject.toml-based projects

Ausli · 2024-02-17T11:44:19Z

I can't compile the project, can't find curl/curl.h, switching to v0.6.0b9 version the problem still exists, can you compile the project properly?

perklet · 2024-02-17T13:38:30Z

You need to check out the Makefile and .github/workflows to see how the build process works.

jjsaunier · 2024-02-24T20:58:48Z

curl_cffi/requests/cookies.py

+                    path is None or cookie.path == path
+            ):
+                dictionary[cookie.name] = cookie.value
+        return dictionary


I don't really understand the purpose here, may be it's expected, but cookie matching is not working like that. You can check official RFC:

https://datatracker.ietf.org/doc/html/rfc6265#section-5.1.3

https://datatracker.ietf.org/doc/html/rfc6265#section-5.1.4

Ausli added 2 commits January 31, 2024 22:23

add cookie.py Cookie to dict

990b1fa

add cookie.py Cookie to dict

9993716

perklet requested changes Jan 31, 2024

View reviewed changes

curl_cffi/requests/cookies.py Outdated Show resolved Hide resolved

curl_cffi/requests/cookies.py Outdated Show resolved Hide resolved

Ausli and others added 2 commits February 1, 2024 22:51

Update curl_cffi/requests/cookies.py

44e3091

Co-authored-by: Yifei Kong <[email protected]>

Update curl_cffi/requests/cookies.py

16fa075

Co-authored-by: Yifei Kong <[email protected]>

Merge branch 'yifeikong:main' into cookie

631d25a

jjsaunier reviewed Feb 24, 2024

View reviewed changes

Ausli closed this Mar 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Cookie to dict #231

Add Cookie to dict #231

Ausli commented Jan 31, 2024

perklet commented Jan 31, 2024

Ausli commented Jan 31, 2024

perklet commented Jan 31, 2024

perklet left a comment

Ausli commented Feb 3, 2024

perklet commented Feb 5, 2024

Ausli commented Feb 14, 2024 •

edited

Loading

perklet commented Feb 15, 2024

Ausli commented Feb 15, 2024

Ausli commented Feb 17, 2024 •

edited

Loading

Ausli commented Feb 17, 2024

perklet commented Feb 17, 2024

jjsaunier Feb 24, 2024 •

edited

Loading

Add Cookie to dict #231

Add Cookie to dict #231

Conversation

Ausli commented Jan 31, 2024

perklet commented Jan 31, 2024

Ausli commented Jan 31, 2024

perklet commented Jan 31, 2024

perklet left a comment

Choose a reason for hiding this comment

Ausli commented Feb 3, 2024

perklet commented Feb 5, 2024

Ausli commented Feb 14, 2024 • edited Loading

perklet commented Feb 15, 2024

Ausli commented Feb 15, 2024

Ausli commented Feb 17, 2024 • edited Loading

Ausli commented Feb 17, 2024

perklet commented Feb 17, 2024

jjsaunier Feb 24, 2024 • edited Loading

Choose a reason for hiding this comment

Ausli commented Feb 14, 2024 •

edited

Loading

Ausli commented Feb 17, 2024 •

edited

Loading

jjsaunier Feb 24, 2024 •

edited

Loading