Updated release path setting #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior, the release path assumed a directory and appended `start_lexical.sh` to it. This meant that the name of the executable was hardcoded in the extension, and that made playing around with packaging tougher. It would also mean that getting lexical to run on windows would be harder. This PR maintains backwards compatibility with the old pattern where you can specify a directory, but also adds the ability to point to an executable file.
scohen
force-pushed
the
improve-release-path
branch
from
cd74f7a to
c0d8827
Compare
Blond11516
approved these changes
Aug 11, 2023
Blond11516
reviewed
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior, the release path assumed a directory and appended
start_lexical.shto it. This meant that the name of the executable was hardcoded in the extension, and that made playing around with packaging tougher. It would also mean that getting lexical to run on windows would be harder.This PR maintains backwards compatibility with the old pattern where you can specify a directory, but also adds the ability to point to an executable file.