Add hotwire-livereload #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is _optional_ and I would totally understand if we reject it because we don't want to add another dependency. But this PR would add livereload functionality to our Rails templates. I've just tested it and it works almost instantly for CSS and JS changes. This is a feature that we used to have for JS with Webpack but lost with the new importmap setup. We've actually never had it for CSS, so it's even fancier than before (yay!). I thought it would be a nice thing to include since it could speed up development for students during project weeks and also help with teachers doing CSS changes in lectures. I'm honestly not sure we need to explain this to students, but if we wanted to, I could add it into our "front-end setup" guide, which is done in some livecodes, or into the Rails Assets lecture. But I think it's such a simple change (literally adding one gem and running a Terminal command) that it's almost not worth the airtime.
juliends
reviewed
Apr 3, 2024
There was a problem hiding this comment.
Hey @ajdubovoy 👋
Personally it's a feature I have appreciated in the past when working with students on project weeks.
If we chose to add it we might need a dedicated slide in the course the first time we will actually use it.
Additionally it can be easily disabled 👌
|
Ok! Maybe the best place to put it would be in the Rails Assets lecture? That way we could explain like "This is what SCSS is...also install this gem and it'll live reload". And yes, I noticed that Terminal command and think it'd be nice to mention in the slide that it can be enabled/disabled |
Eschults
approved these changes
Jun 3, 2024
|
Added in https://github.com/lewagon/karr/pull/1043. Good to merge?~! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is optional and I would totally understand if we reject it because we don't want to add another dependency.
But this PR would add livereload functionality to our Rails templates. I've just tested it and it works almost instantly for CSS and JS changes. This is a feature that we used to have for JS with Webpack but lost with the new importmap setup. We've actually never had it for CSS, so it's even fancier than before (yay!).
I thought it would be a nice thing to include since it could speed up development for students during project weeks and also help with teachers doing CSS changes in lectures.
I'm honestly not sure we need to explain this to students, but if we wanted to, I could add it into our "front-end setup" guide, which is done in some livecodes, or into the Rails Assets lecture. But I think it's such a simple change (literally adding one gem and running a Terminal command) that it's almost not worth the airtime.
Related: