Fix query params handling #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danslapman
force-pushed
the
fix-query-params-handling
branch
3 times, most recently
from
a2e4fd7 to
7f81c00
Compare
Sometimes one can meet query parameter without a value, just a key, for example http://host.domain/app/srvice?wsdl. Mockingbird didn't let to add a condition for checking existing such query parameters. Also, it didn't pass them with proxy request. Another problem was multiple values of one query parameter, e.g. http://host.domain?a=1&a=2. Mockingbird took only the last value and dropped all others.
danslapman
force-pushed
the
fix-query-params-handling
branch
from
7f81c00 to
ebe0629
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Sometimes one can meet query parameter without a value, just a key, for example
http://host.domain/app/srvice?wsdl. Mockingbird didn't let to add a condition for checking existing such query parameters. Also, it didn't pass them with proxy request.Another problem was multiple values of one query parameter, e.g.
http://host.domain?a=1&a=2. Mockingbird took only the last value and dropped all others.@mockingbird/maintainers