Use comprehensions -- ruff check --select=C4

[cclauss]

https://docs.astral.sh/ruff/rules/#flake8-comprehensions-c4

% ruff --select=C4 --statistics

 37	C408	[*] Unnecessary `dict` call (rewrite as a literal)
 8	C405	[*] Unnecessary `list` literal (rewrite as a `set` literal)
 8	C417	[*] Unnecessary `map` usage (rewrite using a `list` comprehension)
 1	C416	[*] Unnecessary `list` comprehension (rewrite using `list()`)

% ruff --select=C4 --fix --unsafe-fixes

Found 54 errors (54 fixed, 0 remaining).

% ruff rule C408

unnecessary-collection-call (C408)

Derived from the flake8-comprehensions linter.

Fix is always available.

What it does

Checks for unnecessary dict, list or tuple calls that can be
rewritten as empty literals.

Why is this bad?

It's unnecessary to call e.g., dict() as opposed to using an empty
literal ({}). The former is slower because the name dict must be
looked up in the global scope in case it has been rebound.

Examples

dict()
dict(a=1, b=2)
list()
tuple()

Use instead:

{}
{"a": 1, "b": 2}
[]
()

Fix safety

This rule's fix is marked as unsafe, as it may occasionally drop comments
when rewriting the call. In most cases, though, comments will be preserved.

Options

• lint.flake8-comprehensions.allow-dict-calls-with-keyword-arguments

[jcjones]

I broke this somehow in a merge; I'll have to get it in the morning.

[cclauss]

I broke this somehow in a merge; I'll have to get it in the morning.

😄 I could not sleep so I rebased it. Ready for your review.