Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VA: Make performRemoteValidation more generic #7847

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

VA: Make performRemoteValidation more generic #7847

wants to merge 1 commit into from
+149 −91

Conversation

beautifulentropy
Copy link
Member

@beautifulentropy beautifulentropy commented Nov 26, 2024 •
edited
Loading

  • Make performRemoteValidation a more generic function that returns a new remoteResult interface
  • Modify the return value of IsCAAValid and PerformValidation to satisfy the remoteResult interface
  • Include compile time checks and tests that pass an arbitrary operation

@beautifulentropy beautifulentropy marked this pull request as ready for review November 26, 2024 16:35
@beautifulentropy beautifulentropy requested a review from a team as a code owner November 26, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jprenken jprenken Awaiting requested review from jprenken jprenken is a code owner automatically assigned from letsencrypt/boulder-developers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@beautifulentropy