Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wfe: use wildcard patterns in HTTP handlers #7791

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

wfe: use wildcard patterns in HTTP handlers #7791

wants to merge 2 commits into from

Commits on Nov 7, 2024

  1. metrics: call ServeHTTP directly 

    This allows us to take advantage of http.ServeMux's wildcard handling. If we
first retrieve the handler for a pattern, and then call it ourselves, the values
in `request.PathValue(...)` do not get filled.
    @jsha
    jsha committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    17efd06 View commit details
    Browse the repository at this point in the history

  2. Switch WFE to using wildcard-style handle patterns

    @jsha
    jsha committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    a3ba841 View commit details
    Browse the repository at this point in the history