Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation on named bind parameters. #7

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

aarongable
Copy link

I wasn't able to find documentation of these in the godoc, so I added it. Also, the README had out-of-date information. It said named bind parameters were only supported for Select, but they are also supported for Exec since 2015 (04b2c71).

The documentation for ExpandSlices was embedded in the DbMap type, which made it hard to read on godoc - the entire documentation was in one large pre block. I moved it up to the package level docs.

Note: this is a recreation of go-gorp#421

I wasn't able to find documentation of these in the godoc, so I added
it. Also, the README had out-of-date information. It said named bind
parameters were only supported for Select, but they are also supported
for Exec since 2015 (04b2c71).

The documentation for ExpandSlices was embedded in the DbMap type, which
made it hard to read on godoc - the entire documentation was in one
large `pre` block. I moved it up to the package level docs.
@aarongable aarongable requested a review from a team as a code owner June 30, 2023 17:39
@aarongable aarongable requested a review from pgporada June 30, 2023 17:39
@pgporada pgporada requested a review from jsha June 30, 2023 18:43
@jsha jsha merged commit a4dac79 into main Jul 5, 2023
@jsha jsha deleted the document-named-bind-parameters branch July 5, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants