feat: add support for "v2-archives" in "v1" format #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"v2-archives" defines the archives, same as "archives". It is added to define Ubuntu Pro archives in chisel-releases with "pro" and "priority" fields (see canonical#160 and canonical#167), while supporting Chisel<=v1.0.0 and chisel-releases "format"<=v1. Since Chisel ignores unknown fields, archives defined in "v2-archives" will be ignored by v1.0.0 but picked up by later versions.
letFunny
reviewed
Dec 9, 2024
zhijie-yang
reviewed
Dec 9, 2024
| @@ -161,7 +172,7 @@ func parseRelease(baseDir, filePath string, data []byte) (*Release, error) { | |||
| if yamlVar.Format != "v1" { | |||
| return nil, fmt.Errorf("%s: unknown format %q", fileName, yamlVar.Format) | |||
| } | |||
| if len(yamlVar.Archives) == 0 { | |||
| if len(yamlVar.Archives)+len(yamlVar.V2Archives) == 0 { | |||
There was a problem hiding this comment.
The temporal variable len(yamlVar.Archives)+len(yamlVar.V2Archives) is used twice, can we give it a name?
There was a problem hiding this comment.
I don't think it's that big of a deal to have a variable for this. Let me know if you have strong preferences for this.
letFunny
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2-archivesdefines the archives, the same asarchives. It is added to define Ubuntu Pro archives in chisel-releases withproandpriorityfields (see canonical#160 and canonical#167), while supporting Chisel<=v1.0.0 and chisel-releasesformat<=v1. Since Chisel ignores unknown fields, archives defined inv2-archiveswill be ignored by v1.0.0 but picked up by later versions.-- ROCKS-1729