Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump most dev dependencies #154

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

adroitwhiz
Copy link
Collaborator

Bumps eslint, prettier, and typescript, along with associated configs. ESLint has a new config format, which I've migrated to.

Newer versions of typescript-eslint and TypeScript seem to have more lints--I've disabled some and manually ignored others.

Prettier v3 is async, so we can't use it in toLeopard. Instead, we continue using v2 there but use v3 for the codebase itself.

Bumps eslint, typescript-eslint, and prettier. eslint now has a new
config format, which I migrated over to.

Also fixes or ignores all non-Prettier lints. Behavior should not
change.

Prettier v3 formats code asynchronously, so we can't use it with
toLeopard. Instead, we use v3 for the codebase and v2 for the API.
@adroitwhiz adroitwhiz requested review from PullJosh and towerofnix July 9, 2024 01:51
Copy link
Member

@towerofnix towerofnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically looks great, just a couple of comments. Thank you!

src/io/leopard/toLeopard.ts Show resolved Hide resolved
src/io/sb3/fromSb3.ts Show resolved Hide resolved
@PullJosh
Copy link
Collaborator

Once this is merged, perhaps it's time for an sb-edit release on npm?

@towerofnix
Copy link
Member

Would in effect involve publishing #122 (affects users), #147 (no affect on users), and this PR ("no" affect on users but good for maintenance). Means saving #150 (affects users) til next - no problem here. This set sounds reasonable to us - good to have compatibility fixes available sooner than later.

Filed #156 for some discussion about a 1.0.0 release in particular, somewhat related to these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants