Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat support: toNumber, toString, string/array ops #159

Merged
merged 3 commits into from
Mar 7, 2023

Conversation

towerofnix
Copy link
Member

Follow-up to #157, supports leopard-js/sb-edit#90. These too are needed for comprehensive Scratch compatibility. (toString technically isn't, but it's cleaner to use consistent casting methods.)

@towerofnix
Copy link
Member Author

@adroitwhiz Changes here should be ready for implementation into #146. They're basically all lifted from scratch-vm.

@towerofnix towerofnix merged commit df63fc9 into leopard-js:master Mar 7, 2023
@towerofnix towerofnix deleted the compat-support branch March 7, 2023 19:30
@PullJosh
Copy link
Collaborator

PullJosh commented Mar 7, 2023

@towerofnix Time for a version bump and new release? If you update the version number with npm version and push those changes to Github, we can create a new release on Github and an action will automatically publish to npm.

Thank you so much for all this work, by the way! And apologies for taking so long to review. Life gets busy 😰

@towerofnix
Copy link
Member Author

Sounds good! I'll give it a version and push. And it's all OK, @adroitwhiz's and my work here all started and ramped up pretty spontaneously so we weren't expecting quick reviews ^_^

@towerofnix
Copy link
Member Author

I'm going to give sb-edit a dependencies update locally and then I'll get both of 'em pushed.

@PullJosh
Copy link
Collaborator

PullJosh commented Mar 7, 2023

Sweet! sb-edit also has the automatic npm publishing set up, so I think the only thing you need me for is redeploying the website after sb-edit has been published. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants