This repository has been archived by the owner on Oct 23, 2020. It is now read-only.
checker update #90
Open
checker update #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/leonardovilarinho/vue-acl/blob/affd849636e24f00c5be6e83faa86d8d6bc9ffe8/source/checker.js#L9 This line doesn't allow a router rule such as: ```js meta: { rule: '*' } ``` to go through, It remains invalid, as it is not a predefined rule, which means this section let's it run through as a simple string: https://github.com/leonardovilarinho/vue-acl/blob/affd849636e24f00c5be6e83faa86d8d6bc9ffe8/source/mixin.js#L36-L40 not being an array and not having a `.generate` function. Event if it got through, by using: ```js meta: { rule: new AclRule('*') } ``` The result of `.generate()` is an array of an array: `[['*']]`, hence the following line: https://github.com/leonardovilarinho/vue-acl/blob/affd849636e24f00c5be6e83faa86d8d6bc9ffe8/source/checker.js#L19 also fails. Consider the mentioned simplification.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vue-acl/source/checker.js
Line 9 in affd849
This line doesn't allow a router rule such as:
to go through, It remains invalid, as it is not a predefined rule, which means this section let's it run through as a simple string:
vue-acl/source/mixin.js
Lines 36 to 40 in affd849
not being an array and not having a
.generatefunction.Event if it got through, by using:
The result of
.generate()is an array of an array:[['*']], hence the following line:vue-acl/source/checker.js
Line 19 in affd849
Consider the mentioned simplification.