-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appdata and desktop files related changes #36
Open
yakushabb
wants to merge
14
commits into
leolost2605:main
Choose a base branch
from
yakushabb:fixtr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GNOME automatically excludes release descriptions on Damned Lies (GNOME Translation Platform). It's a good practice to follow the GNOME way. This can streamline the translation process, allowing translators to focus their efforts on more critical and user-facing aspects of the application.
Add bugtracker, vcs-browser and translate URLs to show bug tracker, source code and translation repositories.
> The `<translation/>` tag is an optional tag which can be added to specify the translation domain used for this software component. It may be used by the AppStream distro metadata generator to determine the translation status of the respective software (e.g. which languages the software is translated into and how complete the translations are). https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-translation
- Make desktop file translatable - Validate desktop file
One line is better than 10 lines
Flathub requires a developer tag and developer ID. Also Appstream decided to use rdns structure for developer ID. It allows reverse-dns IDs like sh.cozy, de.geigi or Fediverse handle (like @user@example.org) > A developer tag with a name child tag must be present. > Only one developer tag is allowed and the name tag also must be present only once in untranslated form. ``` <developer id="tld.vendor"> <name>Developer name</name> </developer> ``` Source: https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#name-summary-and-developer-name > The element should have a id property, containing a unique ID to identify the component developer / development team. It is recommended to use a reverse-DNS name, like org.gnome or io.github.ximion, or a Fediverse handle (like @user@example.org) as ID to achieve a higher chance of uniqueness. Source: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-developer
Rename metainfo.xml as metainfo.xml.in as preparation for translation support
- Create metainfo.xml from metainfo.xml.in to make it translatable - Validate metainfo.xml via appstreamcli
Make the gradebook.desktop and gradebook.metainfo.xml files as translatable.
Activate de.po translation
Add new strings from desktop and metainfo files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review individually.
These changes may seem significant, but they are primarily related to appdata and desktop files.
These patches accomplish three main tasks:
In addition to these changes, this PR contains two translation-related updates: