data: don't ignore data point when unavailable

Ignoring the entire data point when a cURL fails (in other words, when unavailable) leads to a panel with "no data" which is misleading. There actually is data, and maybe it just happens it is "unavailable" to all builds. Or it is unavailable to a single build. To fix this, save the data points even when cURL request fails, and show data as unavailable in the charts. Signed-off-by: Leonardo Graboski Veiga <[email protected]>
leograba · Jan 20, 2024 · 173d63e · 173d63e
1 parent 62fcb12
commit 173d63e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/TorizonOSBuildStatusDataAcquisition/get-build-status.sh b/TorizonOSBuildStatusDataAcquisition/get-build-status.sh
@@ -47,8 +47,8 @@ function insert_into_influxdb() {
             buildstatus="${buildstatus}${job}=\"${jobstatus}\","
             echo "Element: $job     | Value: $jobstatus"
         else
-            echo "Element: $job returned an empty value, skipping this data point"
-            break
+            echo "Element: $job returned an empty value"
+            buildstatus="${buildstatus}${job}=\"Unavailable\","
         fi
     done
 

diff --git a/TorizonOSBuildStatusGrafana/grafana-config/dashboard.json b/TorizonOSBuildStatusGrafana/grafana-config/dashboard.json
@@ -60,6 +60,11 @@
                     "index": 1,
                     "text": "Success"
                   },
+                  "Unavailable": {
+                    "color": "transparent",
+                    "index": 6,
+                    "text": "-"
+                  },
                   "Unstable": {
                     "color": "orange",
                     "index": 2,
@@ -163,6 +168,11 @@
                     "index": 1,
                     "text": "Success"
                   },
+                  "Unavailable": {
+                    "color": "transparent",
+                    "index": 6,
+                    "text": "-"
+                  },
                   "Unstable": {
                     "color": "orange",
                     "index": 2,