Merge pull request #21 from matthieu-foucault/NaN_handling

NaN handling
leoasis · Oct 3, 2016 · 784c966 · 784c966
2 parents 3a2c647 + dd32c34
commit 784c966
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/trackForMutations.js b/src/trackForMutations.js
@@ -25,7 +25,7 @@ function detectMutations(isImmutable, trackedProperty, obj, sameParentRef = fals
 
   const sameRef = prevObj === obj;
 
-  if (sameParentRef && !sameRef) {
+  if (sameParentRef && !sameRef && !Number.isNaN(obj)) {
     return { wasMutated: true, path };
   }
 

diff --git a/test/trackForMutations.spec.js b/test/trackForMutations.spec.js
@@ -226,6 +226,10 @@ describe('trackForMutations', () => {
       fn: (s) => {
         return {...s, foo: {}};
       }
+    },
+    'having a NaN in the state': {
+      getState: () => ({ a:NaN, b: Number.NaN }),
+      fn: (s) => s
     }
   };