Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Handle app Logo in database and auth provider #510

Merged
merged 13 commits into from
Jan 8, 2024
Merged

feat: Handle app Logo in database and auth provider #510

merged 13 commits into from
Jan 8, 2024

Conversation

taorepoara
Copy link
Member

@taorepoara taorepoara commented Dec 13, 2023 •
edited
Loading

About this PR

Closes #506
Closes #507

Technical highlight/advice

How to test my changes

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

@taorepoara taorepoara linked an issue Dec 13, 2023 that may be closed by this pull request
[TASK] Manage app logo in the database #506
Closed
@taorepoara taorepoara changed the title 506 task manage app logo in the database feat: Handle Logo in database Dec 20, 2023
@taorepoara taorepoara marked this pull request as ready for review January 3, 2024 14:44
@taorepoara taorepoara mentioned this pull request Jan 8, 2024
Closed
@taorepoara taorepoara changed the title feat: Handle Logo in database feat: Handle app Logo in database and auth provider Jan 8, 2024
jonas-martinez
jonas-martinez approved these changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@jonas-martinez jonas-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Did not really test it but it looks fine. No complex code and the tests cover everything.
This will need to be actually tested when the front part of the code is done.
Or when we end up converting the thunder client files to Postman.

@jonas-martinez jonas-martinez merged commit 2cd4dcc into main Jan 8, 2024
4 checks passed
@jonas-martinez jonas-martinez deleted the 506-task-manage-app-logo-in-the-database branch January 8, 2024 13:47
@taorepoara
Copy link
Member Author

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-martinez jonas-martinez jonas-martinez approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the app logo in the auth provider [TASK] Manage app logo in the database
2 participants
@taorepoara @jonas-martinez