fix: OpenFaaS max scale label as string and min label to 1 on deploy

lenra-io · Oct 31, 2023 · 1c6f1aa · 1c6f1aa
1 parent 6890689
commit 1c6f1aa
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/apps/lenra/lib/lenra/apps.ex b/apps/lenra/lib/lenra/apps.ex
@@ -335,6 +335,9 @@ defmodule Lenra.Apps do
       update_deployement(deployment, status: :waitingForAppReady)
 
       spawn(fn ->
+        Logger.debug(
+          "#{__MODULE__} start waiting for app ready with params #{inspect(%{build: build, loaded_app: loaded_app, deployment: deployment})}"
+        )
         update_deployement_after_deploy(
           deployment,
           loaded_app.main_env.environment,

diff --git a/libs/application_runner/lib/services/application_services.ex b/libs/application_runner/lib/services/application_services.ex
@@ -14,7 +14,7 @@ defmodule ApplicationRunner.ApplicationServices do
   @min_scale_label "com.openfaas.scale.min"
   @max_scale_label "com.openfaas.scale.max"
   @scale_factor_label "com.openfaas.scale.factor"
-  @min_scale_default "0"
+  @min_scale_default "1"
   @max_scale_default "5"
   @scale_factor_default "10"
 
@@ -206,7 +206,7 @@ defmodule ApplicationRunner.ApplicationServices do
           image_name,
           %{
             @min_scale_label => @min_scale_default,
-            @max_scale_label => replicas,
+            @max_scale_label => to_string(replicas),
             @scale_factor_label => @scale_factor_default
           }
         )
@@ -337,6 +337,7 @@ defmodule ApplicationRunner.ApplicationServices do
 
   defp response({:ok, %Finch.Response{status: status_code}}, :deploy_app)
        when status_code in [200, 202] do
+    Logger.debug("Openfaas application deployed")
     {:ok, status_code}
   end