Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Merge blueDroid and nimBLE version into single codebase #196

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

LeeNX
Copy link

@LeeNX LeeNX commented Oct 22, 2023

Possible covers #142

@lemmingDev how does this look as a PR for you?

I think there are three places would be nice to make cleaner, setBatteryLevel section, BLECharacteristic read section and auth section.

Compile works for setBatteryLevel sketch for both stacks, further testing to follow.

@lemmingDev
Copy link
Owner

Great job! @LeeNX

Haven't had much motivation to add new features to this library recently

With the re-addition of blueDroid into master as an option, simultaneous BLE/Classic BT communication may once again be an option. Sim racers rejoice...

I guess readme should get updated too. Any interest in that? You could then say wonderful things about your recent contributions ;)

Not sure if the -lnx on the end of the version number would stuff up the Arduino library auto-download thingy?

@LeeNX
Copy link
Author

LeeNX commented Oct 26, 2023

Thanks @lemmingDev , still a work in progress. Seems my initial testing was flawed and still need some work. I was hoping that we could do the #define USE_NIMBLE in the sketch, so that the bluetooth stack was selectable at compile time per project, but that is not the case, as least not in my testing. Plus the nimBLE code is failing

~/Documents/Arduino/libraries/ESP32-BLE-Gamepad/BleGamepad.cpp:20:
~/Documents/Arduino/libraries/ESP32-BLE-Gamepad/BleGamepad.h:62:5: error: 'NimBLEHIDDevice' does not name a type; did you mean 'NimBLEDevice'?
     NimBLEHIDDevice *hid;
     ^~~~~~~~~~~~~~~
     NimBLEDevice
~/Documents/Arduino/libraries/ESP32-BLE-Gamepad/BleGamepad.cpp: In constructor 'BleGamepad::BleGamepad(std::__cxx11::string, std::__cxx11::string, uint8_t)':
~/Documents/Arduino/libraries/ESP32-BLE-Gamepad/BleGamepad.cpp:76:104: error: class 'BleGamepad' does not have any field named 'hid'

Once I work them out or if somebody knows how to fix, that would be a great help.

@LeeNX LeeNX marked this pull request as draft October 26, 2023 10:58
@lemmingDev
Copy link
Owner

Any progress on this?

@LeeNX
Copy link
Author

LeeNX commented Feb 26, 2024

Any progress on this?

Sadly no. Been poking at adding charge status, but failing at that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants